From: Matthew Wilcox <willy@infradead.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: filemap: batch mm counter updating in filemap_map_pages()
Date: Fri, 12 Apr 2024 04:17:58 +0100 [thread overview]
Message-ID: <Zhin5gNVk8NHjxPP@casper.infradead.org> (raw)
In-Reply-To: <20240412025704.53245-3-wangkefeng.wang@huawei.com>
On Fri, Apr 12, 2024 at 10:57:04AM +0800, Kefeng Wang wrote:
> } while ((folio = next_uptodate_folio(&xas, mapping, end_pgoff)) != NULL);
> +
> + add_mm_counter(vma->vm_mm, mm_counter_file(folio), rss);
Can't folio be NULL here?
next prev parent reply other threads:[~2024-04-12 3:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 2:57 [PATCH v2 0/2] mm: batch mm counter updating in filemap_map_pages() Kefeng Wang
2024-04-12 2:57 ` [PATCH 1/2] mm: move mm counter updating out of set_pte_range() Kefeng Wang
2024-04-12 2:33 ` Kefeng Wang
2024-04-12 2:57 ` [PATCH 2/2] mm: filemap: batch mm counter updating in filemap_map_pages() Kefeng Wang
2024-04-12 3:17 ` Matthew Wilcox [this message]
2024-04-12 3:49 ` Kefeng Wang
-- strict thread matches above, loose matches on Subject: below --
2024-04-11 13:09 [PATCH 0/2] mm: " Kefeng Wang
2024-04-11 13:09 ` [PATCH 2/2] mm: filemap: " Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zhin5gNVk8NHjxPP@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).