From: Christoph Hellwig <hch@infradead.org>
To: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Ojaswin Mujoo <ojaswin@linux.ibm.com>, Jan Kara <jack@suse.cz>
Subject: Re: [RFC] Documentation: Add initial iomap document
Date: Fri, 3 May 2024 09:41:26 -0700 [thread overview]
Message-ID: <ZjUTtuNqi9o9xgwg@infradead.org> (raw)
In-Reply-To: <17e84cbae600898269e9ad35046ce6dc929036ae.1714744795.git.ritesh.list@gmail.com>
> +i.e. at a high level how iomap does write iter is [1]::
> + user IO
> + loop for file IO range
> + loop for each mapped extent
> + if (buffered) {
> + loop for each page/folio {
> + instantiate page cache
> + copy data to/from page cache
> + update page cache state
> + }
> + } else { /* direct IO */
> + loop for each bio {
> + pack user pages into bio
> + submit bio
> + }
> + }
> + }
> + }
This would probably be easier to follow (and match the actual code)
with two separate flows for buffered vs direct I/O.
The loop for each bio in direct I/O is also not wrong, but maybe a
bit confusing as we really map over a pinned memory range. The code
just has a little optimization to directly place that into a bio.
> +Guideline for filesystem conversion to iomap
> +=============================================
Maybe split this into a separate file?
next prev parent reply other threads:[~2024-05-03 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 14:10 [RFC] Documentation: Add initial iomap document Ritesh Harjani (IBM)
2024-05-03 16:41 ` Christoph Hellwig [this message]
2024-05-12 12:44 ` Jan Kara
2024-06-03 23:34 ` Darrick J. Wong
2024-06-05 4:07 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjUTtuNqi9o9xgwg@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).