From: Matthew Wilcox <willy@infradead.org>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Johannes Thumshirn <jth@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] zonefs: move super block reading from page to folio
Date: Thu, 23 May 2024 12:48:09 +0100 [thread overview]
Message-ID: <Zk8s-ZnFQuKTjY2R@casper.infradead.org> (raw)
In-Reply-To: <7839c762-3e2e-4124-a42f-6c15f3d8fea4@wdc.com>
On Thu, May 23, 2024 at 09:54:00AM +0000, Johannes Thumshirn wrote:
> On 23.05.24 03:42, Matthew Wilcox wrote:
> > I think the right way to handle this is to call read_mapping_folio().
> > That will allocate a folio in the page cache for you (obeying the
> > minimum folio size). Then you can examine the contents. It should
> > actually remove code from zonefs. Don't forget to call folio_put()
> > when you're done with it (either at unmount or at the end of mount if
> > you copy what you need elsewhere).
>
> Hmm but read mapping folio needs an inode for the address_space. Or does
> the block device inode work here?
Sorry, yes, should have been explicit. Read it using the bdev's
address_space.
next prev parent reply other threads:[~2024-05-23 11:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 15:22 [PATCH] zonefs: move super block reading from page to folio Johannes Thumshirn
2024-05-14 19:12 ` Bill O'Donnell
2024-05-23 1:41 ` Matthew Wilcox
2024-05-23 9:54 ` Johannes Thumshirn
2024-05-23 11:48 ` Matthew Wilcox [this message]
2024-05-23 11:49 ` Johannes Thumshirn
2024-05-31 1:16 ` Darrick J. Wong
2024-05-31 1:28 ` Damien Le Moal
2024-06-01 17:51 ` Matthew Wilcox
2024-06-03 0:30 ` Damien Le Moal
2024-06-04 5:33 ` Christoph Hellwig
2024-06-04 22:30 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk8s-ZnFQuKTjY2R@casper.infradead.org \
--to=willy@infradead.org \
--cc=Johannes.Thumshirn@wdc.com \
--cc=dlemoal@kernel.org \
--cc=jth@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).