From: Matthew Wilcox <willy@infradead.org>
To: Johannes Thumshirn <jth@kernel.org>
Cc: Damien Le Moal <dlemoal@kernel.org>,
linux-fsdevel@vger.kernel.org,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH v2] zonefs: move super block reading from page to folio
Date: Thu, 23 May 2024 14:34:27 +0100 [thread overview]
Message-ID: <Zk9F43It82lvM3Nr@casper.infradead.org> (raw)
In-Reply-To: <20240523130153.27537-1-jth@kernel.org>
On Thu, May 23, 2024 at 03:01:53PM +0200, Johannes Thumshirn wrote:
> static int zonefs_read_super(struct super_block *sb)
> {
> struct zonefs_sb_info *sbi = ZONEFS_SB(sb);
> + struct address_space *address_space = sb->s_bdev->bd_inode->i_mapping;
203c1ce0bb06 killed bd_inode. You want
struct address_space *address_space = sb->s_bdev->bd_mapping
> + folio = read_mapping_folio(address_space, 0, NULL);
> + if (IS_ERR(folio))
> + return -EINVAL;
Wouldn't it be better to return PTR_ERR(folio)?
prev parent reply other threads:[~2024-05-23 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 13:01 [PATCH v2] zonefs: move super block reading from page to folio Johannes Thumshirn
2024-05-23 13:10 ` Johannes Thumshirn
2024-05-23 13:34 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk9F43It82lvM3Nr@casper.infradead.org \
--to=willy@infradead.org \
--cc=dlemoal@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=jth@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox