linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "hch@infradead.org" <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: "hch@infradead.org" <hch@infradead.org>,
	Trond Myklebust <trondmy@hammerspace.com>,
	"chuck.lever@oracle.com" <chuck.lever@oracle.com>,
	"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"brauner@kernel.org" <brauner@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"alex.aring@gmail.com" <alex.aring@gmail.com>,
	"cyphar@cyphar.com" <cyphar@cyphar.com>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"jlayton@kernel.org" <jlayton@kernel.org>,
	"amir73il@gmail.com" <amir73il@gmail.com>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH RFC v2] fhandle: expose u64 mount id to name_to_handle_at(2)
Date: Tue, 28 May 2024 03:56:43 -0700	[thread overview]
Message-ID: <ZlW4a6Zdt9SPTt80@infradead.org> (raw)
In-Reply-To: <20240528101152.kyvtx623djnxwonm@quack3>

On Tue, May 28, 2024 at 12:11:52PM +0200, Jan Kara wrote:
> So some fanotify users may use open_by_handle_at() and name_to_handle_at()
> but we specifically designed fanotify to not depend on this mount id
> feature of the API (because it wasn't really usable couple of years ago
> when we were designing this with Amir). fanotify returns fsid + fhandle in
> its events and userspace is expected to build a mapping of fsid ->
> "whatever it needs to identify a filesystem" when placing fanotify marks.
> If it wants to open file / directory where events happened, then this
> usually means keeping fsid -> "some open fd on fs" mapping so that it can
> then use open_by_handle_at() for opening.

Which seems like another argument for my version of the handles to
include the fsid.  Although IIRC the fanotify fsid is only 64 bits which
isn't really good entropy, so we might have to rev that as well.


  reply	other threads:[~2024-05-28 10:56 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-23 20:57 [PATCH RFC v2] fhandle: expose u64 mount id to name_to_handle_at(2) Aleksa Sarai
2024-05-24  4:58 ` Amir Goldstein
2024-05-26  9:25 ` Christoph Hellwig
2024-05-26 19:01   ` Aleksa Sarai
2024-05-27 11:47     ` Christoph Hellwig
2024-05-27 12:29       ` Christian Brauner
2024-05-27 13:17         ` Christian Brauner
2024-05-27 15:47           ` Trond Myklebust
2024-05-28  7:05             ` Christian Brauner
2024-05-27 16:18         ` Christoph Hellwig
2024-05-27 13:34       ` Jan Kara
2024-05-27 16:24         ` Christoph Hellwig
2024-05-28  8:20           ` Christian Brauner
2024-05-28  8:28             ` Christoph Hellwig
2024-05-28  9:17               ` Christian Brauner
2024-05-28 10:55                 ` Christoph Hellwig
2024-05-28 12:04                   ` Christian Brauner
2024-05-28 13:22                     ` Christoph Hellwig
2024-05-28 13:28                       ` Miklos Szeredi
2024-05-29  6:34                         ` Christoph Hellwig
2024-06-01  8:12                         ` Aleksa Sarai
2024-06-03 10:30                           ` Jan Kara
2024-06-04  5:22                           ` Christoph Hellwig
2024-05-29  7:40                       ` Christian Brauner
2024-05-31  8:14                         ` Christoph Hellwig
2024-05-31 10:28                           ` Christian Brauner
2024-05-26 22:32   ` Trond Myklebust
2024-05-27 11:49     ` hch
2024-05-27 15:38       ` Trond Myklebust
2024-05-27 16:29         ` hch
2024-05-28  7:12           ` Christian Brauner
2024-05-28  7:15             ` hch
2024-05-28 10:11           ` Jan Kara
2024-05-28 10:56             ` hch [this message]
2024-05-28 23:25               ` Dave Chinner
2024-05-29  6:24                 ` hch
2024-05-29  7:23                   ` Amir Goldstein
2024-05-27 12:22   ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZlW4a6Zdt9SPTt80@infradead.org \
    --to=hch@infradead.org \
    --cc=alex.aring@gmail.com \
    --cc=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=cyphar@cyphar.com \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@hammerspace.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).