Re: [RFC] fstests: add mmap page boundary tests

[Luis Chamberlain <mcgrof@kernel.org>]

On Tue, Apr 16, 2024 at 04:05:42AM +0800, Zorro Lang wrote:
> On Mon, Apr 15, 2024 at 01:10:54AM -0700, Luis Chamberlain wrote:
> > diff --git a/common/filter b/common/filter
> > index 36d51bd957dd..d7add06f3be7 100644
> > --- a/common/filter
> > +++ b/common/filter
> > @@ -194,6 +194,12 @@ _filter_xfs_io_unique()
> >      common_line_filter | _filter_xfs_io
> >  }
> >  
> > +_filter_xfs_io_data_unique()
> > +{
> > +    _filter_xfs_io_offset | sed -e 's| |\n|g' | egrep -v "\.|XX|\*" | \
> 
> The egrep is deprecated, please use 'grep -E'.
> 
> > +	sort | uniq | tr -d '\n'
> 
> Isn't "sort | uniq" equal to "sort -u" ?

I'll try both suggestions.

> Do we need this filter to be a common helper? Will it be used widely? If not,
> this can be a local function of below single test case.

I suspect it will be but its OK I can stuff it alone, same as for
_mwrite() too then.

  Luis