From: Dave Chinner <david@fromorbit.com>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH] vfs: add rcu-based find_inode variants for iget ops
Date: Fri, 7 Jun 2024 12:04:58 +1000 [thread overview]
Message-ID: <ZmJqyrgPXXjY2Iem@dread.disaster.area> (raw)
In-Reply-To: <20240606140515.216424-1-mjguzik@gmail.com>
On Thu, Jun 06, 2024 at 04:05:15PM +0200, Mateusz Guzik wrote:
> Instantiating a new inode normally takes the global inode hash lock
> twice:
> 1. once to check if it happens to already be present
> 2. once to add it to the hash
>
> The back-to-back lock/unlock pattern is known to degrade performance
> significantly, which is further exacerbated if the hash is heavily
> populated (long chains to walk, extending hold time). Arguably hash
> sizing and hashing algo need to be revisited, but that's beyond the
> scope of this patch.
>
> A long term fix would introduce fine-grained locking, this was attempted
> in [1], but that patchset was already posted several times and appears
> stalled.
Why not just pick up those patches and drive them to completion?
I have no issues with somebody else doing the finishing work for
that code; several of the patches in that series were originally
written by other people in the first place...
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2024-06-07 2:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 14:05 [RFC PATCH] vfs: add rcu-based find_inode variants for iget ops Mateusz Guzik
2024-06-06 16:31 ` Jan Kara
2024-06-06 18:45 ` Mateusz Guzik
2024-06-07 2:04 ` Dave Chinner [this message]
2024-06-07 7:51 ` Mateusz Guzik
2024-06-11 10:17 ` Dave Chinner
2024-06-11 11:13 ` Mateusz Guzik
2024-06-11 11:28 ` Jan Kara
2024-06-11 22:00 ` Dave Chinner
2024-06-13 10:50 ` Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmJqyrgPXXjY2Iem@dread.disaster.area \
--to=david@fromorbit.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox