From: Christoph Hellwig <hch@infradead.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org, josef@toxicpanda.com
Subject: Re: [PATCH v2 1/2] vfs: add rcu-based find_inode variants for iget ops
Date: Mon, 10 Jun 2024 22:20:26 -0700 [thread overview]
Message-ID: <ZmfemrY9ZPnvmocu@infradead.org> (raw)
In-Reply-To: <CAGudoHE12-7c0kmVpKz8HyBeHt8jX8hOQ7zQxZNJ0Re7FF8r6g@mail.gmail.com>
On Tue, Jun 11, 2024 at 07:17:41AM +0200, Mateusz Guzik wrote:
>
> I agree, but this is me just copying and modifying an existing line.
>
> include/linux/fs.h is chock full of extern-prefixed func declarations,
> on top of that some name the arguments while the rest does not.
>
> Someone(tm) should definitely clean it up, but I'm not interested in
> bikeshedding about it.
No one asked you to clean the mess up, but don't add any in changed
or added lines. Without that:
Nacked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-06-11 5:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 19:58 [PATCH v2 0/2] rcu-based inode lookup for iget* Mateusz Guzik
2024-06-10 19:58 ` [PATCH v2 1/2] vfs: add rcu-based find_inode variants for iget ops Mateusz Guzik
2024-06-11 4:59 ` Christoph Hellwig
2024-06-11 5:17 ` Mateusz Guzik
2024-06-11 5:20 ` Christoph Hellwig [this message]
2024-06-11 5:36 ` Mateusz Guzik
2024-06-11 6:05 ` Christoph Hellwig
2024-06-10 19:58 ` [PATCH v2 2/2] btrfs: use iget5_locked_rcu Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmfemrY9ZPnvmocu@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).