linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 2/2] ext4: Remove array of buffer_heads from mext_page_mkuptodate()
Date: Thu, 18 Jul 2024 23:35:19 +0100	[thread overview]
Message-ID: <ZpmYp-ci47MZ6c9T@casper.infradead.org> (raw)
In-Reply-To: <20240627202022.GC419129@mit.edu>

On Thu, Jun 27, 2024 at 04:20:22PM -0400, Theodore Ts'o wrote:
> This patch is causing ext4/020 (which tests the EXT4_IOC_MOVE_EXT
> ioctl used by e4defrag).  This can be easily reproduced via:
> "kvm-xfstests -c ext4/4k ext4/020".  From
> /results/ext4/results-4k/ext4/020.out.bad:
> 
>    QA output created by 020
>    wrote 1048576/1048576 bytes at offset 0
>    XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>    wrote 1023/1023 bytes at offset 0
>    XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>    md5sum: WARNING: 1 computed checksum did NOT match
>    SCRATCH_MNT/020.orig: FAILED
> 
> I'm going to drop both this patch and the preceeding patch in this
> series ("ext4: reduce stack usage in ext4_mpage_readpages()") pending
> further investigation.

Thanks.  I couldn't get kvm-xfstests to work, but I was able to run
ext4/020 using Kent's testsuite.  I found two bugs and fixed them.
I split this second patch into three patches for v2.

      reply	other threads:[~2024-07-18 22:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 18:16 [PATCH 1/2] ext4: Reduce stack usage in ext4_mpage_readpages() Matthew Wilcox (Oracle)
2024-05-16 18:16 ` [PATCH 2/2] ext4: Remove array of buffer_heads from mext_page_mkuptodate() Matthew Wilcox (Oracle)
2024-06-27 20:20   ` Theodore Ts'o
2024-07-18 22:35     ` Matthew Wilcox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZpmYp-ci47MZ6c9T@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=hare@suse.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).