From: Christoph Hellwig <hch@infradead.org>
To: Dongliang Cui <dongliang.cui@unisoc.com>
Cc: linkinjeon@kernel.org, sj1557.seo@samsung.com, hch@infradead.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
niuzhiguo84@gmail.com, hao_hao.wang@unisoc.com,
ke.wang@unisoc.com, Zhiguo Niu <zhiguo.niu@unisoc.com>
Subject: Re: [PATCH v3] exfat: check disk status during buffer write
Date: Wed, 31 Jul 2024 08:54:50 -0700 [thread overview]
Message-ID: <ZqpeSvEgVtIWrWVr@infradead.org> (raw)
In-Reply-To: <20240731022715.4044482-1-dongliang.cui@unisoc.com>
Besides the additional checks for the shutdown flag already mentioned
the subject is now incorrect I think, it should talk about implementing
shutdown handling.
In case you haven't done so yet, please also see if exfat now passes
the various testcases in xfstests that exercise the shutdown path.
Otherwise this looks reasonable to me, thanks for the work!
next prev parent reply other threads:[~2024-07-31 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 2:27 [PATCH v3] exfat: check disk status during buffer write Dongliang Cui
2024-07-31 7:26 ` Namjae Jeon
2024-07-31 15:54 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-07-31 2:31 崔东亮 (Dongliang Cui)
2024-08-01 5:29 崔东亮 (Dongliang Cui)
2024-08-01 5:54 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqpeSvEgVtIWrWVr@infradead.org \
--to=hch@infradead.org \
--cc=dongliang.cui@unisoc.com \
--cc=hao_hao.wang@unisoc.com \
--cc=ke.wang@unisoc.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niuzhiguo84@gmail.com \
--cc=sj1557.seo@samsung.com \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).