From: Matthew Wilcox <willy@infradead.org>
To: Greg Ungerer <gregungerer@westnet.com.au>
Cc: Christian Brauner <brauner@kernel.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 12/16] romfs: Convert romfs_read_folio() to use a folio
Date: Mon, 12 Aug 2024 04:30:06 +0100 [thread overview]
Message-ID: <ZrmBvo6c1N7YnJ6y@casper.infradead.org> (raw)
In-Reply-To: <597dd1bb-43ee-4531-8869-c46b38df56bd@westnet.com.au>
On Mon, Aug 12, 2024 at 11:46:34AM +1000, Greg Ungerer wrote:
> > @@ -125,20 +121,14 @@ static int romfs_read_folio(struct file *file, struct folio *folio)
> > ret = romfs_dev_read(inode->i_sb, pos, buf, fillsize);
> > if (ret < 0) {
> > - SetPageError(page);
> > fillsize = 0;
> > ret = -EIO;
> > }
> > }
> > - if (fillsize < PAGE_SIZE)
> > - memset(buf + fillsize, 0, PAGE_SIZE - fillsize);
> > - if (ret == 0)
> > - SetPageUptodate(page);
> > -
> > - flush_dcache_page(page);
> > - kunmap(page);
> > - unlock_page(page);
> > + buf = folio_zero_tail(folio, fillsize, buf);
I think this should have been:
buf = folio_zero_tail(folio, fillsize, buf + fillsize);
Can you give that a try?
next prev parent reply other threads:[~2024-08-12 3:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 20:20 [PATCH 00/16] Prepare to remove PG_error Matthew Wilcox (Oracle)
2024-05-30 20:20 ` [PATCH 01/16] befs: Convert befs_symlink_read_folio() to use folio_end_read() Matthew Wilcox (Oracle)
2024-05-30 20:20 ` [PATCH 02/16] coda: Convert coda_symlink_filler() " Matthew Wilcox (Oracle)
2024-05-30 20:20 ` [PATCH 03/16] cramfs: Convert cramfs_read_folio to use a folio Matthew Wilcox (Oracle)
2024-05-30 20:20 ` [PATCH 04/16] efs: Convert efs_symlink_read_folio " Matthew Wilcox (Oracle)
2024-05-30 20:20 ` [PATCH 05/16] hpfs: Convert hpfs_symlink_read_folio " Matthew Wilcox (Oracle)
2024-05-30 20:20 ` [PATCH 06/16] isofs: Convert rock_ridge_symlink_read_folio " Matthew Wilcox (Oracle)
2024-05-30 20:20 ` [PATCH 07/16] hostfs: Convert hostfs_read_folio() " Matthew Wilcox (Oracle)
2024-05-30 20:21 ` [PATCH 08/16] jffs2: Remove calls to set/clear the folio error flag Matthew Wilcox (Oracle)
2024-05-30 20:21 ` [PATCH 09/16] nfs: Remove calls to folio_set_error Matthew Wilcox (Oracle)
2024-05-30 20:21 ` [PATCH 10/16] orangefs: Remove calls to set/clear the error flag Matthew Wilcox (Oracle)
2024-05-30 20:21 ` [PATCH 11/16] reiserfs: Remove call to folio_set_error() Matthew Wilcox (Oracle)
2024-05-30 20:21 ` [PATCH 12/16] romfs: Convert romfs_read_folio() to use a folio Matthew Wilcox (Oracle)
2024-08-12 1:46 ` Greg Ungerer
2024-08-12 3:30 ` Matthew Wilcox [this message]
2024-08-12 4:36 ` Greg Ungerer
2024-08-14 19:32 ` Matthew Wilcox
2024-08-15 12:42 ` Christian Brauner
2024-08-26 1:34 ` Greg Ungerer
2024-08-26 10:42 ` Christian Brauner
2024-05-30 20:21 ` [PATCH 13/16] ufs: Remove call to set the folio error flag Matthew Wilcox (Oracle)
2024-05-30 20:21 ` [PATCH 14/16] vboxsf: Convert vboxsf_read_folio() to use a folio Matthew Wilcox (Oracle)
2024-05-30 20:21 ` [PATCH 15/16] iomap: Remove calls to set and clear folio error flag Matthew Wilcox (Oracle)
2024-05-30 20:21 ` [PATCH 16/16] buffer: Remove calls to set and clear the " Matthew Wilcox (Oracle)
2024-05-31 10:34 ` [PATCH 00/16] Prepare to remove PG_error Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrmBvo6c1N7YnJ6y@casper.infradead.org \
--to=willy@infradead.org \
--cc=brauner@kernel.org \
--cc=gregungerer@westnet.com.au \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).