* [PATCH] unicode: constify utf8 data table
@ 2024-08-09 15:38 Thomas Weißschuh
2024-08-12 6:45 ` Christoph Hellwig
2024-08-13 19:22 ` Gabriel Krisman Bertazi
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Weißschuh @ 2024-08-09 15:38 UTC (permalink / raw)
To: Gabriel Krisman Bertazi
Cc: linux-fsdevel, linux-kernel, Thomas Weißschuh
All users already handle the table as const data.
Move the table itself into .rodata to guard against accidental or
malicious modifications.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
fs/unicode/mkutf8data.c | 2 +-
fs/unicode/utf8data.c_shipped | 2 +-
fs/unicode/utf8n.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/unicode/mkutf8data.c b/fs/unicode/mkutf8data.c
index 77b685db8275..57e0e290ce6f 100644
--- a/fs/unicode/mkutf8data.c
+++ b/fs/unicode/mkutf8data.c
@@ -3338,7 +3338,7 @@ static void write_file(void)
}
fprintf(file, "};\n");
fprintf(file, "\n");
- fprintf(file, "struct utf8data_table utf8_data_table = {\n");
+ fprintf(file, "const struct utf8data_table utf8_data_table = {\n");
fprintf(file, "\t.utf8agetab = utf8agetab,\n");
fprintf(file, "\t.utf8agetab_size = ARRAY_SIZE(utf8agetab),\n");
fprintf(file, "\n");
diff --git a/fs/unicode/utf8data.c_shipped b/fs/unicode/utf8data.c_shipped
index dafa5fed761d..73a93d49b3ba 100644
--- a/fs/unicode/utf8data.c_shipped
+++ b/fs/unicode/utf8data.c_shipped
@@ -4107,7 +4107,7 @@ static const unsigned char utf8data[64256] = {
0x81,0x80,0xcf,0x86,0x85,0x84,0xcf,0x86,0xcf,0x06,0x02,0x00,0x00,0x00,0x00,0x00
};
-struct utf8data_table utf8_data_table = {
+const struct utf8data_table utf8_data_table = {
.utf8agetab = utf8agetab,
.utf8agetab_size = ARRAY_SIZE(utf8agetab),
diff --git a/fs/unicode/utf8n.h b/fs/unicode/utf8n.h
index bd00d587747a..fc703aa4b28e 100644
--- a/fs/unicode/utf8n.h
+++ b/fs/unicode/utf8n.h
@@ -78,6 +78,6 @@ struct utf8data_table {
const unsigned char *utf8data;
};
-extern struct utf8data_table utf8_data_table;
+extern const struct utf8data_table utf8_data_table;
#endif /* UTF8NORM_H */
---
base-commit: ee9a43b7cfe2d8a3520335fea7d8ce71b8cabd9d
change-id: 20240809-unicode-const-2cd2295d3df3
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] unicode: constify utf8 data table
2024-08-09 15:38 [PATCH] unicode: constify utf8 data table Thomas Weißschuh
@ 2024-08-12 6:45 ` Christoph Hellwig
2024-08-13 19:22 ` Gabriel Krisman Bertazi
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2024-08-12 6:45 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: Gabriel Krisman Bertazi, linux-fsdevel, linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] unicode: constify utf8 data table
2024-08-09 15:38 [PATCH] unicode: constify utf8 data table Thomas Weißschuh
2024-08-12 6:45 ` Christoph Hellwig
@ 2024-08-13 19:22 ` Gabriel Krisman Bertazi
1 sibling, 0 replies; 3+ messages in thread
From: Gabriel Krisman Bertazi @ 2024-08-13 19:22 UTC (permalink / raw)
To: Thomas Weißschuh; +Cc: linux-fsdevel, linux-kernel
On Fri, 09 Aug 2024 17:38:53 +0200, Thomas Weißschuh wrote:
> All users already handle the table as const data.
> Move the table itself into .rodata to guard against accidental or
> malicious modifications.
Applied, thanks!
[1/1] unicode: constify utf8 data table
commit: 43bf9d9755bd21970d8382dc88f071f74fc18fbf
Best regards,
--
Gabriel Krisman Bertazi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-13 19:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-09 15:38 [PATCH] unicode: constify utf8 data table Thomas Weißschuh
2024-08-12 6:45 ` Christoph Hellwig
2024-08-13 19:22 ` Gabriel Krisman Bertazi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).