* Re: [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super()
2024-08-27 23:15 [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super() Nathan Chancellor
@ 2024-08-27 23:47 ` Darrick J. Wong
2024-08-28 10:23 ` Pankaj Raghav (Samsung)
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Darrick J. Wong @ 2024-08-27 23:47 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Christian Brauner, Chandan Babu R, Pankaj Raghav,
Luis Chamberlain, Dave Chinner, linux-xfs, linux-fsdevel, patches
On Tue, Aug 27, 2024 at 04:15:05PM -0700, Nathan Chancellor wrote:
> When building for a 32-bit architecture, where 'size_t' is 'unsigned
> int', there is a warning due to use of '%ld', the specifier for a 'long
> int':
>
> In file included from fs/xfs/xfs_linux.h:82,
> from fs/xfs/xfs.h:26,
> from fs/xfs/xfs_super.c:7:
> fs/xfs/xfs_super.c: In function 'xfs_fs_fill_super':
> fs/xfs/xfs_super.c:1654:1: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1655 | mp->m_sb.sb_blocksize, max_folio_size);
> | ~~~~~~~~~~~~~~
> | |
> | size_t {aka unsigned int}
> ...
> fs/xfs/xfs_super.c:1654:58: note: format string is defined here
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ~~^
> | |
> | long int
> | %d
>
> Use the proper 'size_t' specifier, '%zu', to resolve the warning.
>
> Fixes: 0ab3ca31b012 ("xfs: enable block size larger than page size support")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Yep.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 242271298a33..e8cc7900911e 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1651,7 +1651,7 @@ xfs_fs_fill_super(
>
> if (mp->m_sb.sb_blocksize > max_folio_size) {
> xfs_warn(mp,
> -"block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> +"block size (%u bytes) not supported; Only block size (%zu) or less is supported",
> mp->m_sb.sb_blocksize, max_folio_size);
> error = -ENOSYS;
> goto out_free_sb;
>
> ---
> base-commit: f143d1a48d6ecce12f5bced0d18a10a0294726b5
> change-id: 20240827-xfs-fix-wformat-bs-gt-ps-967f3aa1c142
>
> Best regards,
> --
> Nathan Chancellor <nathan@kernel.org>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super()
2024-08-27 23:15 [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super() Nathan Chancellor
2024-08-27 23:47 ` Darrick J. Wong
@ 2024-08-28 10:23 ` Pankaj Raghav (Samsung)
2024-08-28 21:26 ` Luis Chamberlain
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Pankaj Raghav (Samsung) @ 2024-08-28 10:23 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Christian Brauner, Chandan Babu R, Darrick J. Wong, Pankaj Raghav,
Luis Chamberlain, Dave Chinner, linux-xfs, linux-fsdevel, patches
On Tue, Aug 27, 2024 at 04:15:05PM -0700, Nathan Chancellor wrote:
> When building for a 32-bit architecture, where 'size_t' is 'unsigned
> int', there is a warning due to use of '%ld', the specifier for a 'long
> int':
>
> In file included from fs/xfs/xfs_linux.h:82,
> from fs/xfs/xfs.h:26,
> from fs/xfs/xfs_super.c:7:
> fs/xfs/xfs_super.c: In function 'xfs_fs_fill_super':
> fs/xfs/xfs_super.c:1654:1: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1655 | mp->m_sb.sb_blocksize, max_folio_size);
> | ~~~~~~~~~~~~~~
> | |
> | size_t {aka unsigned int}
> ...
> fs/xfs/xfs_super.c:1654:58: note: format string is defined here
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ~~^
> | |
> | long int
> | %d
>
> Use the proper 'size_t' specifier, '%zu', to resolve the warning.
>
> Fixes: 0ab3ca31b012 ("xfs: enable block size larger than page size support")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Looks good,
Reviewed-by: Pankaj Raghav <p.raghav@samsung.com>
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 242271298a33..e8cc7900911e 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1651,7 +1651,7 @@ xfs_fs_fill_super(
>
> if (mp->m_sb.sb_blocksize > max_folio_size) {
> xfs_warn(mp,
> -"block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> +"block size (%u bytes) not supported; Only block size (%zu) or less is supported",
> mp->m_sb.sb_blocksize, max_folio_size);
> error = -ENOSYS;
> goto out_free_sb;
>
> ---
> base-commit: f143d1a48d6ecce12f5bced0d18a10a0294726b5
> change-id: 20240827-xfs-fix-wformat-bs-gt-ps-967f3aa1c142
>
> Best regards,
> --
> Nathan Chancellor <nathan@kernel.org>
>
--
Pankaj Raghav
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super()
2024-08-27 23:15 [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super() Nathan Chancellor
2024-08-27 23:47 ` Darrick J. Wong
2024-08-28 10:23 ` Pankaj Raghav (Samsung)
@ 2024-08-28 21:26 ` Luis Chamberlain
2024-08-29 3:46 ` Matthew Wilcox
2024-09-03 13:02 ` Christian Brauner
4 siblings, 0 replies; 8+ messages in thread
From: Luis Chamberlain @ 2024-08-28 21:26 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Christian Brauner, Chandan Babu R, Darrick J. Wong, Pankaj Raghav,
Dave Chinner, linux-xfs, linux-fsdevel, patches
On Tue, Aug 27, 2024 at 04:15:05PM -0700, Nathan Chancellor wrote:
> When building for a 32-bit architecture, where 'size_t' is 'unsigned
> int', there is a warning due to use of '%ld', the specifier for a 'long
> int':
>
> In file included from fs/xfs/xfs_linux.h:82,
> from fs/xfs/xfs.h:26,
> from fs/xfs/xfs_super.c:7:
> fs/xfs/xfs_super.c: In function 'xfs_fs_fill_super':
> fs/xfs/xfs_super.c:1654:1: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1655 | mp->m_sb.sb_blocksize, max_folio_size);
> | ~~~~~~~~~~~~~~
> | |
> | size_t {aka unsigned int}
> ...
> fs/xfs/xfs_super.c:1654:58: note: format string is defined here
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ~~^
> | |
> | long int
> | %d
>
> Use the proper 'size_t' specifier, '%zu', to resolve the warning.
>
> Fixes: 0ab3ca31b012 ("xfs: enable block size larger than page size support")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super()
2024-08-27 23:15 [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super() Nathan Chancellor
` (2 preceding siblings ...)
2024-08-28 21:26 ` Luis Chamberlain
@ 2024-08-29 3:46 ` Matthew Wilcox
2024-08-29 5:20 ` Darrick J. Wong
2024-08-29 17:50 ` Nathan Chancellor
2024-09-03 13:02 ` Christian Brauner
4 siblings, 2 replies; 8+ messages in thread
From: Matthew Wilcox @ 2024-08-29 3:46 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Christian Brauner, Chandan Babu R, Darrick J. Wong, Pankaj Raghav,
Luis Chamberlain, Dave Chinner, linux-xfs, linux-fsdevel, patches
On Tue, Aug 27, 2024 at 04:15:05PM -0700, Nathan Chancellor wrote:
> When building for a 32-bit architecture, where 'size_t' is 'unsigned
> int', there is a warning due to use of '%ld', the specifier for a 'long
> int':
>
> In file included from fs/xfs/xfs_linux.h:82,
> from fs/xfs/xfs.h:26,
> from fs/xfs/xfs_super.c:7:
> fs/xfs/xfs_super.c: In function 'xfs_fs_fill_super':
> fs/xfs/xfs_super.c:1654:1: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1655 | mp->m_sb.sb_blocksize, max_folio_size);
> | ~~~~~~~~~~~~~~
> | |
> | size_t {aka unsigned int}
> ...
> fs/xfs/xfs_super.c:1654:58: note: format string is defined here
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ~~^
> | |
> | long int
> | %d
Do we really need the incredibly verbose compiler warning messages?
Can't we just say "this is the wrong format specifier on 32 bit"
and be done with it?
> Use the proper 'size_t' specifier, '%zu', to resolve the warning.
>
> Fixes: 0ab3ca31b012 ("xfs: enable block size larger than page size support")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 242271298a33..e8cc7900911e 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1651,7 +1651,7 @@ xfs_fs_fill_super(
>
> if (mp->m_sb.sb_blocksize > max_folio_size) {
> xfs_warn(mp,
> -"block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> +"block size (%u bytes) not supported; Only block size (%zu) or less is supported",
> mp->m_sb.sb_blocksize, max_folio_size);
> error = -ENOSYS;
> goto out_free_sb;
>
> ---
> base-commit: f143d1a48d6ecce12f5bced0d18a10a0294726b5
> change-id: 20240827-xfs-fix-wformat-bs-gt-ps-967f3aa1c142
>
> Best regards,
> --
> Nathan Chancellor <nathan@kernel.org>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super()
2024-08-29 3:46 ` Matthew Wilcox
@ 2024-08-29 5:20 ` Darrick J. Wong
2024-08-29 17:50 ` Nathan Chancellor
1 sibling, 0 replies; 8+ messages in thread
From: Darrick J. Wong @ 2024-08-29 5:20 UTC (permalink / raw)
To: Matthew Wilcox
Cc: Nathan Chancellor, Christian Brauner, Chandan Babu R,
Pankaj Raghav, Luis Chamberlain, Dave Chinner, linux-xfs,
linux-fsdevel, patches
On Thu, Aug 29, 2024 at 04:46:41AM +0100, Matthew Wilcox wrote:
> On Tue, Aug 27, 2024 at 04:15:05PM -0700, Nathan Chancellor wrote:
> > When building for a 32-bit architecture, where 'size_t' is 'unsigned
> > int', there is a warning due to use of '%ld', the specifier for a 'long
> > int':
> >
> > In file included from fs/xfs/xfs_linux.h:82,
> > from fs/xfs/xfs.h:26,
> > from fs/xfs/xfs_super.c:7:
> > fs/xfs/xfs_super.c: In function 'xfs_fs_fill_super':
> > fs/xfs/xfs_super.c:1654:1: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
> > 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 1655 | mp->m_sb.sb_blocksize, max_folio_size);
> > | ~~~~~~~~~~~~~~
> > | |
> > | size_t {aka unsigned int}
> > ...
> > fs/xfs/xfs_super.c:1654:58: note: format string is defined here
> > 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> > | ~~^
> > | |
> > | long int
> > | %d
>
> Do we really need the incredibly verbose compiler warning messages?
> Can't we just say "this is the wrong format specifier on 32 bit"
> and be done with it?
Clearly you haven't f*cked up^W^Wforgotten a comma in an xfs tracepoint
in a while, those will generate 60 pages of helpful diagnostics.
--D
> > Use the proper 'size_t' specifier, '%zu', to resolve the warning.
> >
> > Fixes: 0ab3ca31b012 ("xfs: enable block size larger than page size support")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > ---
> > fs/xfs/xfs_super.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> > index 242271298a33..e8cc7900911e 100644
> > --- a/fs/xfs/xfs_super.c
> > +++ b/fs/xfs/xfs_super.c
> > @@ -1651,7 +1651,7 @@ xfs_fs_fill_super(
> >
> > if (mp->m_sb.sb_blocksize > max_folio_size) {
> > xfs_warn(mp,
> > -"block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> > +"block size (%u bytes) not supported; Only block size (%zu) or less is supported",
> > mp->m_sb.sb_blocksize, max_folio_size);
> > error = -ENOSYS;
> > goto out_free_sb;
> >
> > ---
> > base-commit: f143d1a48d6ecce12f5bced0d18a10a0294726b5
> > change-id: 20240827-xfs-fix-wformat-bs-gt-ps-967f3aa1c142
> >
> > Best regards,
> > --
> > Nathan Chancellor <nathan@kernel.org>
> >
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super()
2024-08-29 3:46 ` Matthew Wilcox
2024-08-29 5:20 ` Darrick J. Wong
@ 2024-08-29 17:50 ` Nathan Chancellor
1 sibling, 0 replies; 8+ messages in thread
From: Nathan Chancellor @ 2024-08-29 17:50 UTC (permalink / raw)
To: Matthew Wilcox
Cc: Christian Brauner, Chandan Babu R, Darrick J. Wong, Pankaj Raghav,
Luis Chamberlain, Dave Chinner, linux-xfs, linux-fsdevel, patches
On Thu, Aug 29, 2024 at 04:46:41AM +0100, Matthew Wilcox wrote:
> On Tue, Aug 27, 2024 at 04:15:05PM -0700, Nathan Chancellor wrote:
> > When building for a 32-bit architecture, where 'size_t' is 'unsigned
> > int', there is a warning due to use of '%ld', the specifier for a 'long
> > int':
> >
> > In file included from fs/xfs/xfs_linux.h:82,
> > from fs/xfs/xfs.h:26,
> > from fs/xfs/xfs_super.c:7:
> > fs/xfs/xfs_super.c: In function 'xfs_fs_fill_super':
> > fs/xfs/xfs_super.c:1654:1: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
> > 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 1655 | mp->m_sb.sb_blocksize, max_folio_size);
> > | ~~~~~~~~~~~~~~
> > | |
> > | size_t {aka unsigned int}
> > ...
> > fs/xfs/xfs_super.c:1654:58: note: format string is defined here
> > 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> > | ~~^
> > | |
> > | long int
> > | %d
>
> Do we really need the incredibly verbose compiler warning messages?
> Can't we just say "this is the wrong format specifier on 32 bit"
> and be done with it?
Sure, I could have been less verbose. I seem to recall maintainers
desiring the full compiler output at times so that it is easier to see
what the issue is and how the patch fixes the warning but obviously that
is going to vary from maintainer to maintainer. I can send a v2 with
that trimmed if desired or Christian could just axe it when applying if
he really cares? I guess squashing this into the original change would
make this irrelevant too.
> > Use the proper 'size_t' specifier, '%zu', to resolve the warning.
> >
> > Fixes: 0ab3ca31b012 ("xfs: enable block size larger than page size support")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > ---
> > fs/xfs/xfs_super.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> > index 242271298a33..e8cc7900911e 100644
> > --- a/fs/xfs/xfs_super.c
> > +++ b/fs/xfs/xfs_super.c
> > @@ -1651,7 +1651,7 @@ xfs_fs_fill_super(
> >
> > if (mp->m_sb.sb_blocksize > max_folio_size) {
> > xfs_warn(mp,
> > -"block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> > +"block size (%u bytes) not supported; Only block size (%zu) or less is supported",
> > mp->m_sb.sb_blocksize, max_folio_size);
> > error = -ENOSYS;
> > goto out_free_sb;
> >
> > ---
> > base-commit: f143d1a48d6ecce12f5bced0d18a10a0294726b5
> > change-id: 20240827-xfs-fix-wformat-bs-gt-ps-967f3aa1c142
> >
> > Best regards,
> > --
> > Nathan Chancellor <nathan@kernel.org>
> >
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super()
2024-08-27 23:15 [PATCH] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super() Nathan Chancellor
` (3 preceding siblings ...)
2024-08-29 3:46 ` Matthew Wilcox
@ 2024-09-03 13:02 ` Christian Brauner
4 siblings, 0 replies; 8+ messages in thread
From: Christian Brauner @ 2024-09-03 13:02 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Christian Brauner, Chandan Babu R, Darrick J. Wong, Pankaj Raghav,
Luis Chamberlain, Dave Chinner, linux-xfs, linux-fsdevel, patches
On Tue, 27 Aug 2024 16:15:05 -0700, Nathan Chancellor wrote:
> When building for a 32-bit architecture, where 'size_t' is 'unsigned
> int', there is a warning due to use of '%ld', the specifier for a 'long
> int':
>
> In file included from fs/xfs/xfs_linux.h:82,
> from fs/xfs/xfs.h:26,
> from fs/xfs/xfs_super.c:7:
> fs/xfs/xfs_super.c: In function 'xfs_fs_fill_super':
> fs/xfs/xfs_super.c:1654:1: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1655 | mp->m_sb.sb_blocksize, max_folio_size);
> | ~~~~~~~~~~~~~~
> | |
> | size_t {aka unsigned int}
> ...
> fs/xfs/xfs_super.c:1654:58: note: format string is defined here
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ~~^
> | |
> | long int
> | %d
>
> [...]
The fix has been folded into the commit it fixes and a Link tag has been added
noting that this patch has been folded. Thanks!
---
Applied to the vfs.blocksize branch of the vfs/vfs.git tree.
Patches in the vfs.blocksize branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.blocksize
[1/1] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super()
(no commit info)
^ permalink raw reply [flat|nested] 8+ messages in thread