From: Christoph Hellwig <hch@infradead.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
gfs2@lists.linux.dev, linux-block@vger.kernel.org,
dlemoal@kernel.org, djwong@kernel.org, brauner@kernel.org
Subject: Re: [PATCH][RFC] iomap: add a private argument for iomap_file_buffered_write
Date: Tue, 27 Aug 2024 03:55:19 -0700 [thread overview]
Message-ID: <Zs2wl4u72hxRq_VU@infradead.org> (raw)
In-Reply-To: <7f55c7c32275004ba00cddf862d970e6e633f750.1724755651.git.josef@toxicpanda.com>
On Tue, Aug 27, 2024 at 06:51:36AM -0400, Josef Bacik wrote:
> In order to switch fuse over to using iomap for buffered writes we need
> to be able to have the struct file for the original write, in case we
> have to read in the page to make it uptodate. Handle this by using the
> existing private field in the iomap_iter, and add the argument to
> iomap_file_buffered_write. This will allow us to pass the file in
> through the iomap buffered write path, and is flexible for any other
> file systems needs.
No, we need my version of this :)
http://git.infradead.org/?p=users/hch/xfs.git;a=commitdiff;h=84e044c2d18b2ba8ca6b8001d7cec54d3c972e89
Looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-08-27 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 10:51 [PATCH][RFC] iomap: add a private argument for iomap_file_buffered_write Josef Bacik
2024-08-27 10:55 ` Christoph Hellwig [this message]
2024-08-27 11:03 ` Josef Bacik
2024-08-27 11:07 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs2wl4u72hxRq_VU@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=gfs2@lists.linux.dev \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).