From: Christoph Hellwig <hch@infradead.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-fsdevel@vger.kernel.org, amir73il@gmail.com,
miklos@szeredi.hu, joannelkoong@gmail.com, bschubert@ddn.com
Subject: Re: [PATCH 06/11] fuse: use iomap for writeback cache buffered writes
Date: Tue, 27 Aug 2024 22:16:37 -0700 [thread overview]
Message-ID: <Zs6ytd-L9u6D45PI@infradead.org> (raw)
In-Reply-To: <11b0ac855816688f6ae9a6653ddb0b814a62c3bc.1724791233.git.josef@toxicpanda.com>
On Tue, Aug 27, 2024 at 04:45:19PM -0400, Josef Bacik wrote:
> We're currently using the old ->write_begin()/->write_end() method of
> doing buffered writes. This isn't a huge deal for fuse since we
> basically just want to copy the pages and move on, but the iomap
> infrastructure gives us access to having huge folios. Rework the
> buffered write path when we have writeback cache to use the iomap
> buffered write code, the ->get_folio() callback now handles the work
> that we did in ->write_begin(), the rest of the work is handled inside
> of iomap so we don't need a replacement for ->write_end.
Fuse probably needs to select FS_IOMAP with this. And BLOCK as
well as buffered-io.o depends on it, but I suspect that is relatvely
easily fixable.
next prev parent reply other threads:[~2024-08-28 5:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 20:45 [PATCH 00/11] fuse: convert to using folios and iomap Josef Bacik
2024-08-27 20:45 ` [PATCH 01/11] fuse: convert readahead to use folios Josef Bacik
2024-08-27 21:46 ` Matthew Wilcox
2024-08-27 22:23 ` Josef Bacik
2024-08-27 20:45 ` [PATCH 02/11] fuse: convert fuse_send_write_pages " Josef Bacik
2024-08-27 21:53 ` Matthew Wilcox
2024-08-27 22:24 ` Josef Bacik
2024-08-27 20:45 ` [PATCH 03/11] fuse: convert fuse_fill_write_pages " Josef Bacik
2024-08-27 21:30 ` Joanne Koong
2024-08-27 22:25 ` Josef Bacik
2024-08-27 20:45 ` [PATCH 04/11] fuse: convert fuse_page_mkwrite " Josef Bacik
2024-08-27 20:45 ` [PATCH 05/11] fuse: use kiocb_modified in buffered write path Josef Bacik
2024-08-27 20:45 ` [PATCH 06/11] fuse: use iomap for writeback cache buffered writes Josef Bacik
2024-08-28 5:16 ` Christoph Hellwig [this message]
2024-08-27 20:45 ` [PATCH 07/11] fuse: convert fuse_do_readpage to use folios Josef Bacik
2024-08-27 20:45 ` [PATCH 08/11] fuse: convert fuse_writepage_need_send to take a folio Josef Bacik
2024-08-27 20:45 ` [PATCH 09/11] fuse: use the folio based vmstat helpers Josef Bacik
2024-08-27 22:05 ` Joanne Koong
2024-08-27 20:45 ` [PATCH 10/11] fuse: convert fuse_retrieve to use folios Josef Bacik
2024-08-27 22:10 ` Joanne Koong
2024-08-27 20:45 ` [PATCH 11/11] fuse: convert fuse_notify_store " Josef Bacik
2024-08-27 21:36 ` [PATCH 00/11] fuse: convert to using folios and iomap Bernd Schubert
2024-08-27 22:18 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs6ytd-L9u6D45PI@infradead.org \
--to=hch@infradead.org \
--cc=amir73il@gmail.com \
--cc=bschubert@ddn.com \
--cc=joannelkoong@gmail.com \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).