From: Matthew Wilcox <willy@infradead.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.com>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH] bcachefs: Switch to memalloc_flags_do() for vmalloc allocations
Date: Wed, 28 Aug 2024 19:48:43 +0100 [thread overview]
Message-ID: <Zs9xC3OJPbkMy25C@casper.infradead.org> (raw)
In-Reply-To: <20240828140638.3204253-1-kent.overstreet@linux.dev>
On Wed, Aug 28, 2024 at 10:06:36AM -0400, Kent Overstreet wrote:
> vmalloc doesn't correctly respect gfp flags - gfp flags aren't used for
> pte allocation, so doing vmalloc/kvmalloc allocations with reclaim
> unsafe locks is a potential deadlock.
Kent, the approach you've taken with this was NACKed. You merged it
anyway (!). Now you're spreading this crap further, presumably in an effort
to make it harder to remove.
Stop it. Work with us to come up with an acceptable approach. I
think there is one that will work, but you need to listen to the people
who're giving you feedback because Linux is too big of a code-base for
you to understand everything.
next prev parent reply other threads:[~2024-08-28 18:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 14:06 [PATCH] bcachefs: Switch to memalloc_flags_do() for vmalloc allocations Kent Overstreet
2024-08-28 18:48 ` Matthew Wilcox [this message]
2024-08-28 19:11 ` Kent Overstreet
2024-08-28 19:26 ` Michal Hocko
2024-08-28 22:58 ` Kent Overstreet
2024-08-29 7:19 ` Michal Hocko
2024-08-29 11:41 ` Kent Overstreet
2024-08-29 11:08 ` Michal Hocko
2024-08-29 11:55 ` Kent Overstreet
2024-08-29 12:34 ` Michal Hocko
2024-08-29 12:42 ` Kent Overstreet
2024-08-29 14:27 ` Dave Chinner
2024-08-30 3:39 ` Theodore Ts'o
2024-08-31 15:46 ` Kent Overstreet
2024-08-30 9:14 ` Yafang Shao
2024-08-30 15:25 ` Vlastimil Babka
2024-09-02 3:00 ` Yafang Shao
2024-09-01 3:35 ` Dave Chinner
2024-09-02 3:02 ` Yafang Shao
2024-09-02 8:11 ` Michal Hocko
2024-09-02 9:01 ` Yafang Shao
2024-09-02 9:09 ` Michal Hocko
2024-09-03 6:34 ` Yafang Shao
2024-09-03 7:18 ` Michal Hocko
2024-09-03 12:44 ` Theodore Ts'o
2024-09-03 13:15 ` Yafang Shao
2024-09-03 14:03 ` Michal Hocko
2024-09-03 13:30 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs9xC3OJPbkMy25C@casper.infradead.org \
--to=willy@infradead.org \
--cc=dchinner@redhat.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).