From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B357194AF6 for ; Mon, 26 Aug 2024 16:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724691247; cv=none; b=l9JwHhdnIZ8qqCcnNSjD7M38DsKkTlphmmYvtLoubvgvkGOm6aeSaiQObYqDuFWXR0WVlQk1kNDuijGopEk8r1IiB2QaOrlDHJ4bkNI3C/hYaH0GkaqHWppvTvBiII1dG/HyPjG81PrITHfPG/lVse882H4pLlONBl0q+sD/zo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724691247; c=relaxed/simple; bh=SrrYymcdbDLizvS79/RRUElJG4frmyAuzrjQG6kpUYg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VeP8hbGYRwKNK/Y2gvjd2ggiQixPGElP3zSKpdMAV/pDDT48xt4Xlpd+wGhVYHopF3lN9+lvkPZKmFHg/pNT06wvW9Q0R/0gQ42yQ/wL61QQWCNSbNF5dtT33YRh72U0hYAq6Pimz49uSeBx/e3TOQMfcf53EIKfcpQYjRr+YVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=NqB7pnFI; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="NqB7pnFI" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a83562f9be9so413656166b.0 for ; Mon, 26 Aug 2024 09:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724691244; x=1725296044; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=AuNkNTNASSkVHyZwptKwTsvU1aOshMXolrmNLp6jKyI=; b=NqB7pnFInPxLsopP4yeDHM3L5xm7QFZkJ5UteTNfoADN7u95ugBbLEbUGFXYiGYdYg +as1d0i1H2RIVsr8P2YrX6AR0+FEBLrm87xN1l2XGJU1N1lN4j1CbGXih/ZuyybGYiGT vo1Uv3Hl1eV+Z+vFBxQ4hQ7dxalGJZJg3qIM3PlrHWuSGV9HljD/S+/8A44EhvhZO+ue YlBOtqW5kbAkqPoP050njWJgOv+bmgDbD1YiBLvFu7EuE5QwDaLrCYm9s2Ob11g3GKb7 AsIRKBui3RFELkLkrr/rs1QAq3iIX7D8WGiVdCdxDLm7e3/n9XClRkZriSe15u+PSwIR 291g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724691244; x=1725296044; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AuNkNTNASSkVHyZwptKwTsvU1aOshMXolrmNLp6jKyI=; b=VuAZDXNbHt/WbQR9n9bwf/davAAlpkseKvVd9eoH6WqtjCfHyPW5vHotAnDVBM2ogc 5tYiiK7wZf0ZQfbT3DdP3r5TR1+l98keyuUYBioCstowxMNxudo7W41eBCFSroXoKOlc iWSQ9YbVWa2quxjAuq3DLYXJKudBQRcQdTYeau42bBAih26m59OAuFd8N5AtuV96/YN5 B9N31eU/OKP9EPgdGoDOEczWPqW8ZMbpKSVuxQNDqPuMhBRgr18GfSn1XO/0ZJnSA7Xl qH2u+FhFaoaUfwI8xqQqxLxSdB/SkBuCskzSt52nK+oMRlvFWyXSZMy1ZZgP2V38Xr7Y 8tbw== X-Forwarded-Encrypted: i=1; AJvYcCXoNngNEXt8ezNN+XgO3SYZJB9qPbK+HrDppHj2RNPtJJ3BPmDe41Z6CapCKkY7LbYOdqNPmHa3pHwD+7Am@vger.kernel.org X-Gm-Message-State: AOJu0Yx19B1Q0Vfb2128n+1s01k86U5MjDlBqQc6MnHK7GLEPFqVQVQA nMU1i9leVqpJQmZfwJHbNCCspDp+7K0Hwlc3gjkeZ6wXUxL/H0k2p5B1g2CyhU3muTRwLOaOf61 o X-Google-Smtp-Source: AGHT+IGqicfaj3+0I5vKnr31dtF3PG61H07IprF3n2t7ZPxM1+pfgLfSyChrmgA9n5aCTBY9B2eIuA== X-Received: by 2002:a17:907:2d0a:b0:a77:f2c5:84b3 with SMTP id a640c23a62f3a-a86a5199093mr691568166b.22.1724691243592; Mon, 26 Aug 2024 09:54:03 -0700 (PDT) Received: from localhost (109-81-92-122.rct.o2.cz. [109.81.92.122]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f2e66eesm687492566b.97.2024.08.26.09.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 09:54:03 -0700 (PDT) Date: Mon, 26 Aug 2024 18:54:02 +0200 From: Michal Hocko To: Yafang Shao Cc: Andrew Morton , Christoph Hellwig , Kent Overstreet , jack@suse.cz, Christian Brauner , Alexander Viro , Paul Moore , James Morris , "Serge E. Hallyn" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-bcachefs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: drop PF_MEMALLOC_NORECLAIM Message-ID: References: <20240826085347.1152675-1-mhocko@kernel.org> <20240826085347.1152675-3-mhocko@kernel.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon 26-08-24 21:48:34, Yafang Shao wrote: > On Mon, Aug 26, 2024 at 4:53 PM Michal Hocko wrote: > > > > From: Michal Hocko > > > > There is no existing user of the flag and the flag is dangerous because > > a nested allocation context can use GFP_NOFAIL which could cause > > unexpected failure. Such a code would be hard to maintain because it > > could be deeper in the call chain. > > > > PF_MEMALLOC_NORECLAIM has been added even when it was pointed out [1] > > that such a allocation contex is inherently unsafe if the context > > doesn't fully control all allocations called from this context. > > > > [1] https://lore.kernel.org/all/ZcM0xtlKbAOFjv5n@tiehlicka/ > > > > Signed-off-by: Michal Hocko > > --- > > include/linux/sched.h | 1 - > > include/linux/sched/mm.h | 7 ++----- > > 2 files changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > index f8d150343d42..72dad3a6317a 100644 > > --- a/include/linux/sched.h > > +++ b/include/linux/sched.h > > @@ -1657,7 +1657,6 @@ extern struct pid *cad_pid; > > * I am cleaning dirty pages from some other bdi. */ > > #define PF_KTHREAD 0x00200000 /* I am a kernel thread */ > > #define PF_RANDOMIZE 0x00400000 /* Randomize virtual address space */ > > -#define PF_MEMALLOC_NORECLAIM 0x00800000 /* All allocation requests will clear __GFP_DIRECT_RECLAIM */ > > To maintain consistency with the other unused bits, it would be better > to define PF__HOLE__00800000 instead. OK -- Michal Hocko SUSE Labs