From: Matthew Wilcox <willy@infradead.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Yafang Shao <laoar.shao@gmail.com>,
jack@suse.cz, Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-bcachefs@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM
Date: Mon, 26 Aug 2024 20:41:42 +0100 [thread overview]
Message-ID: <Zszado75SnObVKG5@casper.infradead.org> (raw)
In-Reply-To: <egma4j7om4jcrxwpks6odx6wu2jc5q3qdboncwsja32mo4oe7r@qmiviwad32lm>
On Mon, Aug 26, 2024 at 03:39:47PM -0400, Kent Overstreet wrote:
> Given the amount of plumbing required here, it's clear that passing gfp
> flags is the less safe way of doing it, and this really does belong in
> the allocation context.
>
> Failure to pass gfp flags correctly (which we know is something that
> happens today, e.g. vmalloc -> pte allocation) means you're introducing
> a deadlock.
The problem with vmalloc is that the page table allocation _doesn't_
take a GFP parameter.
next prev parent reply other threads:[~2024-08-26 19:41 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 8:47 [PATCH 0/2] get rid of PF_MEMALLOC_NORECLAIM Michal Hocko
2024-08-26 8:47 ` [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM Michal Hocko
2024-08-26 13:11 ` Matthew Wilcox
2024-08-26 16:48 ` Michal Hocko
2024-08-26 19:39 ` Kent Overstreet
2024-08-26 19:41 ` Matthew Wilcox [this message]
2024-08-26 19:42 ` Kent Overstreet
2024-08-26 19:47 ` Matthew Wilcox
2024-08-26 19:54 ` Kent Overstreet
2024-08-26 19:44 ` Kent Overstreet
2024-08-26 19:58 ` Michal Hocko
2024-08-26 20:00 ` Kent Overstreet
2024-08-26 20:27 ` Michal Hocko
2024-08-26 20:43 ` Kent Overstreet
2024-08-26 21:10 ` Kent Overstreet
2024-08-27 6:01 ` Michal Hocko
2024-08-27 6:40 ` Kent Overstreet
2024-08-27 6:58 ` Michal Hocko
2024-08-27 7:05 ` Kent Overstreet
2024-08-27 7:35 ` Michal Hocko
2024-08-26 19:52 ` kernel test robot
2024-08-26 20:53 ` kernel test robot
2024-08-27 2:23 ` kernel test robot
2024-08-27 6:15 ` [PATCH 1/2 v2] " Michal Hocko
2024-08-27 12:29 ` Christoph Hellwig
2024-08-28 4:09 ` Dave Chinner
2024-08-29 10:02 ` Kent Overstreet
2024-08-29 13:12 ` Dave Chinner
2024-08-29 13:22 ` Kent Overstreet
2024-08-29 13:32 ` Kent Overstreet
2024-08-29 14:03 ` Yafang Shao
2024-09-02 0:23 ` Dave Chinner
2024-09-02 1:35 ` Kent Overstreet
2024-09-02 8:41 ` Michal Hocko
2024-09-02 8:52 ` Kent Overstreet
2024-09-02 9:39 ` Michal Hocko
2024-09-02 9:51 ` Kent Overstreet
2024-09-02 14:07 ` Jonathan Corbet
2024-09-04 18:01 ` Shuah Khan
2024-11-20 20:34 ` Kent Overstreet
2024-11-20 21:12 ` Shuah Khan
2024-11-20 21:20 ` Kent Overstreet
2024-11-20 21:37 ` Shuah Khan
2024-11-20 22:21 ` Shuah Khan
2024-11-20 22:39 ` Kent Overstreet
2024-11-20 22:55 ` Kent Overstreet
2024-11-20 23:21 ` Kent Overstreet
2024-11-20 23:47 ` Theodore Ts'o
2024-11-20 23:57 ` Kent Overstreet
2024-11-21 0:10 ` Kent Overstreet
2024-11-21 4:25 ` Christoph Hellwig
2024-11-21 4:53 ` Kent Overstreet
2024-11-21 23:53 ` Shuah Khan
2024-11-22 6:51 ` Kent Overstreet
2024-11-22 12:06 ` Christoph Hellwig
2024-11-21 21:32 ` Martin Steigerwald
2024-11-22 9:47 ` Geert Uytterhoeven
2024-11-21 5:51 ` Kent Overstreet
2024-11-21 8:43 ` review process (was: underalated stuff) Michal Hocko
2024-11-21 9:03 ` Kent Overstreet
2024-11-21 20:17 ` [PATCH 1/2 v2] bcachefs: do not use PF_MEMALLOC_NORECLAIM Simona Vetter
2024-11-21 21:26 ` Martin Steigerwald
2024-11-22 21:48 ` Dan Williams
2024-11-22 22:02 ` Kent Overstreet
2024-08-29 9:37 ` [PATCH 1/2] " Jan Kara
2024-08-26 8:47 ` [PATCH 2/2] mm: drop PF_MEMALLOC_NORECLAIM Michal Hocko
2024-08-26 13:48 ` Yafang Shao
2024-08-26 16:54 ` Michal Hocko
2024-08-26 13:59 ` Matthew Wilcox
2024-08-26 16:51 ` Michal Hocko
2024-08-26 17:49 ` Matthew Wilcox
2024-08-26 19:18 ` Michal Hocko
2024-08-26 19:20 ` Matthew Wilcox
2024-08-28 4:11 ` Dave Chinner
2024-08-29 21:45 ` Vlastimil Babka
2024-08-26 19:04 ` Kent Overstreet
2024-08-27 12:29 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2024-09-02 9:51 [PATCH 0/2 v2] remove PF_MEMALLOC_NORECLAIM Michal Hocko
2024-09-02 9:51 ` [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM Michal Hocko
2024-09-05 9:28 ` kernel test robot
2024-09-26 17:11 [PATCH 0/2 v3] remove PF_MEMALLOC_NORECLAIM Michal Hocko
2024-09-26 17:11 ` [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zszado75SnObVKG5@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jmorris@namei.org \
--cc=kent.overstreet@linux.dev \
--cc=laoar.shao@gmail.com \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).