Re: [PATCH v14 15/25] nfs_common: introduce nfs_localio_ctx struct and interfaces

[Mike Snitzer <snitzer@kernel.org>]

On Fri, Aug 30, 2024 at 03:46:31PM +1000, NeilBrown wrote:
> On Thu, 29 Aug 2024, Mike Snitzer wrote:
> > +
> > +struct nfs_localio_ctx {
> > +	struct nfsd_file *nf;
> > +	struct nfsd_net *nn;
> > +};
> 
> struct nfsd_file contains "struct net *nf_net" which is initialised
> early.
> So this structure is redundant.

Oof, unwinding returning nfs_localio_ctx and going back to nfsd_file it is.
 
> Instead of exporting nfsd_file_put() to nfs-localio, export
> nfsd_file_local_put() (or whatever) which both does the nfs_serv_put()
> and the nfsd_file_put().

OK, no more.. I have to catch up! ;)