From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E715413959D for ; Mon, 2 Sep 2024 09:09:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725268147; cv=none; b=ZnSOFr1fujUAMGl03HUDcyfGLwb6JgV2Opi75l7X/7ZArQrsjcB9HZGFYphlyszJih60yzLEavsuKxIhPSoRzP9/WLm/JIW7hO9m23pve+ZElkL/vh2kEKZsjZBKBH2qqUKOTNe2W/PFEWbAAP5u7E0Xk69F4OcHMO1bynLi0ck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725268147; c=relaxed/simple; bh=pKJ69WgBoUOku0xgyepPvpHKeJ+qYkm2Mu/uS+vlzsg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rYSJCCCkq33rxOGWZVl3fmM5ml7XCyiPZwcYBZHMjauZXkSLw842HGdyS1DMpV/gYStcKHWfpjKbCueDNyBBoctaKyr2kiJ9OV+0p1Hzku+wVTFiL47a+DF7K4jGTDTEwqbyikQAtS8gSSDYTQ2xzru5bCkQXYX9ZQgSeDj9Evc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SZMzq1Ma; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SZMzq1Ma" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2f43de7ad5eso51390271fa.1 for ; Mon, 02 Sep 2024 02:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725268144; x=1725872944; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Tc+tIxGI3WkXrC4GyS0UazwJpXd6EeGAj+AW+8MBy5w=; b=SZMzq1Maq5rch+kT1AkfH9/43lrTYsSgLojebAUsI1qKoVG/VyQWRwCX+rS8hzSqOj eroSfimKCjnRqO5dv0I5DW/y5ggeB3U9Hu6geX2UILI1Mfn//p/kYmFo8vDKR7UuFeOf BT4guze6Zbq5hxd4NENyGGK/fh8YKAqO1Zs3rffkD7i3lujC8p2FiieT82Kxpy5h7+e7 eoBtOKIxjkXYzyma3SNiDuzVkkwYErj/vbMtT2bIEAs1zbESPu4iLYnpBspQBeW/vmY4 wVqr9e81XAvJCNUn9bnVLanj4Lslndn7Ci85A6CHA7DtBbfcEyz9YgvStRwrcedAT1MM jJXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725268144; x=1725872944; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tc+tIxGI3WkXrC4GyS0UazwJpXd6EeGAj+AW+8MBy5w=; b=j2I2WUYlu7NGGRgPp5ib1Pw6gVZu2wZZ8wXAUOzLFtz+7rja94azKypx06falEmMO/ VrKyO1bk9t7gbxDuPD/KQujoBPB6ip/KIE2/sfa4Bj2iLqURtXDA8rwaf5cFWNxwXG93 Rk0mkVpbakAHDYkElMH9tnzuliHuEl0rGNx68DHx/iPc9X12Hup6u5re56Tb7GhSB1fI a/mwZO3+7m9D56tLr6AHkXrOb5Ewf2PkySQDSO6bGDuXGR/UWIx3dDnmO/IIPCzuvU5/ Z8J9INl3A9vjNr451Be7i+PvqXhT8os00UtQbY32+IwNeN+YhYrbqp3Rcqe+lo9bLEhG H7uA== X-Forwarded-Encrypted: i=1; AJvYcCVvV9S6AAFfg4YIiiT6Fc1E/i7H+mLYvP+ymqTVXMXJ2T4XbJMasi0ko0fwE/DJiRLKRFNl5Uio+3jlXyku@vger.kernel.org X-Gm-Message-State: AOJu0YxsArR6EQg6bfFm3b49mqLYqBpXNMwo5r5ZP4e6ZryU7oXuokuV SyvZElIMvPYTVrjJEILVnqAgi/KdP/ZKzAJsiO6f9C2su8WwLHZOjfE57wSYBAk= X-Google-Smtp-Source: AGHT+IGE/GtNjsdfXTxeqr6p9FrfimaHQ9FGSfSyoXGsx0BhwbDRvvlZ17A524C8LUpRaD0LGFd9aA== X-Received: by 2002:a05:6512:3da9:b0:530:ae4a:58d0 with SMTP id 2adb3069b0e04-53546af3605mr6730057e87.8.1725268143851; Mon, 02 Sep 2024 02:09:03 -0700 (PDT) Received: from localhost (109-81-82-19.rct.o2.cz. [109.81.82.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a89891d6fa9sm528702166b.162.2024.09.02.02.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 02:09:03 -0700 (PDT) Date: Mon, 2 Sep 2024 11:09:02 +0200 From: Michal Hocko To: Yafang Shao Cc: Dave Chinner , Kent Overstreet , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Chinner Subject: Re: [PATCH] bcachefs: Switch to memalloc_flags_do() for vmalloc allocations Message-ID: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon 02-09-24 17:01:12, Yafang Shao wrote: > > I really do not see why GFP_NOFAIL should be any special in this > > specific case. > > I believe there's no way to stop it from looping, even if you > implement a sophisticated user space OOM killer. ;) User space OOM killer should be helping to replenish a free memory and we have some heuristics to help NOFAIL users out with some portion of memory reserves already IIRC. So we do already give them some special treatment in the page allocator path. Not so much in the reclaim path. -- Michal Hocko SUSE Labs