From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 896121E492; Tue, 3 Sep 2024 16:38:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725381508; cv=none; b=T++WO783FrpPY2vc9wHmTyuQ9vTv7Gg6qYWIK8ebms8lxNym3DKtIVpMI6tBKTx79U5XvzA98yl228oWt7tIUUqtPjYokc3c232Nk+DrfsLoEtcO/xTTJu3duuvM/hvdUOnLQLEhXQYgt7jBBwsAEyiAlr1YtciKr58VSHEKYd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725381508; c=relaxed/simple; bh=Ch4EB9z7SxI24U7kqiSf5J+jgI5aAF15vq3HqTETrBM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=icu5rb78oz2n6lVIP1F409yDGst5OIkMCOLc87ztgcnepa51hvYzlLCqrEo3RPqGoXHscQh3OBDu3TQQnb4zrsXgPhJuktx4xM5LIcGxEUX+HheLpIg39gCEn94qGxKpLYvKMfeG4roj3Gq3lh+iUTBuYzMIU5bttOqcr3tkXv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 697ECC4CEC4; Tue, 3 Sep 2024 16:38:22 +0000 (UTC) Date: Tue, 3 Sep 2024 17:38:20 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v12 26/39] arm64/ptrace: Expose GCS via ptrace and core files Message-ID: References: <20240829-arm64-gcs-v12-0-42fec947436a@kernel.org> <20240829-arm64-gcs-v12-26-42fec947436a@kernel.org> <3f190f54-477e-48dd-8a57-8d61ea20413b@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f190f54-477e-48dd-8a57-8d61ea20413b@sirena.org.uk> On Mon, Sep 02, 2024 at 07:58:28PM +0100, Mark Brown wrote: > On Mon, Sep 02, 2024 at 07:56:32PM +0100, Catalin Marinas wrote: > > On Thu, Aug 29, 2024 at 12:27:42AM +0100, Mark Brown wrote: > > > > +static int gcs_get(struct task_struct *target, > > > + const struct user_regset *regset, > > > + struct membuf to) > > > > + if (target == current) > > > + gcs_preserve_current_state(); > > > What's the use-case where target == current and do we need something > > similar for gcs_set()? > > IIRC core file generation so no. Ah, true. Makes sense. -- Catalin