* [PATCH -next] fs/inode: Modify mismatched function name
@ 2024-09-13 1:10 Jiapeng Chong
2024-09-13 10:29 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Jiapeng Chong @ 2024-09-13 1:10 UTC (permalink / raw)
To: viro; +Cc: brauner, jack, linux-fsdevel, linux-kernel, Jiapeng Chong,
Abaci Robot
No functional modification involved.
fs/inode.c:242: warning: expecting prototype for inode_init_always(). Prototype was for inode_init_always_gfp() instead.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10845
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/inode.c b/fs/inode.c
index c391365cdfa7..6763900a7a87 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -229,7 +229,7 @@ static int no_open(struct inode *inode, struct file *file)
}
/**
- * inode_init_always - perform inode structure initialisation
+ * inode_init_always_gfp - perform inode structure initialisation
* @sb: superblock inode belongs to
* @inode: inode to initialise
* @gfp: allocation flags
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fs/inode: Modify mismatched function name
2024-09-13 1:10 [PATCH -next] fs/inode: Modify mismatched function name Jiapeng Chong
@ 2024-09-13 10:29 ` Jan Kara
2024-09-13 11:32 ` Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2024-09-13 10:29 UTC (permalink / raw)
To: Jiapeng Chong
Cc: viro, brauner, jack, linux-fsdevel, linux-kernel, Abaci Robot,
mhocko
On Fri 13-09-24 09:10:04, Jiapeng Chong wrote:
> No functional modification involved.
>
> fs/inode.c:242: warning: expecting prototype for inode_init_always(). Prototype was for inode_init_always_gfp() instead.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10845
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
I think this is a fallout from Michal's patch [1] which will be respinned
anyway AFAIU. Michal, can you please fixup the kernel doc when sending new
version of the patch? Thanks!
Honza
[1] https://lore.kernel.org/all/20240827061543.1235703-1-mhocko@kernel.org/
> ---
> fs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/inode.c b/fs/inode.c
> index c391365cdfa7..6763900a7a87 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -229,7 +229,7 @@ static int no_open(struct inode *inode, struct file *file)
> }
>
> /**
> - * inode_init_always - perform inode structure initialisation
> + * inode_init_always_gfp - perform inode structure initialisation
> * @sb: superblock inode belongs to
> * @inode: inode to initialise
> * @gfp: allocation flags
> --
> 2.32.0.3.g01195cf9f
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fs/inode: Modify mismatched function name
2024-09-13 10:29 ` Jan Kara
@ 2024-09-13 11:32 ` Michal Hocko
0 siblings, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2024-09-13 11:32 UTC (permalink / raw)
To: Jan Kara
Cc: Jiapeng Chong, viro, brauner, linux-fsdevel, linux-kernel,
Abaci Robot
On Fri 13-09-24 12:29:35, Jan Kara wrote:
> On Fri 13-09-24 09:10:04, Jiapeng Chong wrote:
> > No functional modification involved.
> >
> > fs/inode.c:242: warning: expecting prototype for inode_init_always(). Prototype was for inode_init_always_gfp() instead.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10845
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> I think this is a fallout from Michal's patch [1] which will be respinned
> anyway AFAIU. Michal, can you please fixup the kernel doc when sending new
> version of the patch? Thanks!
Yes, I will. Thanks for heads up.
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-13 11:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-13 1:10 [PATCH -next] fs/inode: Modify mismatched function name Jiapeng Chong
2024-09-13 10:29 ` Jan Kara
2024-09-13 11:32 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).