From: Liviu Dudau <Liviu.Dudau@arm.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Jeff Layton <jlayton@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Josef Bacik <josef@toxicpanda.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: move FMODE_UNSIGNED_OFFSET to fop_flags
Date: Fri, 20 Sep 2024 00:55:57 +0100 [thread overview]
Message-ID: <Zuy6Daji_OFn8NFf@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <20240919-kollabieren-seeweg-f780e1d5e9f8@brauner>
On Thu, Sep 19, 2024 at 03:03:19PM +0200, Christian Brauner wrote:
> On Wed, Sep 18, 2024 at 02:40:46PM GMT, Liviu Dudau wrote:
> > Hi Christian,
> >
> > > This is another flag that is statically set and doesn't need to use up
> > > an FMODE_* bit. Move it to ->fop_flags and free up another FMODE_* bit.
> > >
> > > (1) mem_open() used from proc_mem_operations
> > > (2) adi_open() used from adi_fops
> > > (3) drm_open_helper():
> > > (3.1) accel_open() used from DRM_ACCEL_FOPS
> > > (3.2) drm_open() used from
> > > (3.2.1) amdgpu_driver_kms_fops
> > > (3.2.2) psb_gem_fops
> > > (3.2.3) i915_driver_fops
> > > (3.2.4) nouveau_driver_fops
> > > (3.2.5) panthor_drm_driver_fops
> > > (3.2.6) radeon_driver_kms_fops
> > > (3.2.7) tegra_drm_fops
> > > (3.2.8) vmwgfx_driver_fops
> > > (3.2.9) xe_driver_fops
> > > (3.2.10) DRM_GEM_FOPS
> > > (3.2.11) DEFINE_DRM_GEM_DMA_FOPS
> > > (4) struct memdev sets fmode flags based on type of device opened. For
> > > devices using struct mem_fops unsigned offset is used.
> > >
> > > Mark all these file operations as FOP_UNSIGNED_OFFSET and add asserts
> > > into the open helper to ensure that the flag is always set.
> > >
> > > Signed-off-by: Christian Brauner <brauner@kernel.org>
> >
> > Your patch seems to be missing the panthor_drm_driver_fops changes. I've
> > discovered that on linux-next your patch triggers a WARN() during my testing.
>
> Yeah, I've added a WARN_ON_ONCE() to catch such cases. Good that it worked.
>
> >
> > I've added the following change to my local tree to fix the warning.
>
> I would send a fixes PR soon. Do you want me to send a fix for this
> along with this or are you taking this upstream soon yourself?
Was your series pulled into v6.12?
I will send a patch and once reviewed I will push it into the relevant drm-misc branch.
Best regards,
Liviu
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
next prev parent reply other threads:[~2024-09-19 23:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 13:40 [PATCH] fs: move FMODE_UNSIGNED_OFFSET to fop_flags Liviu Dudau
2024-09-19 13:03 ` Christian Brauner
2024-09-19 23:55 ` Liviu Dudau [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-08-09 10:38 Christian Brauner
2024-08-09 12:23 ` Jeff Layton
2024-08-09 17:14 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zuy6Daji_OFn8NFf@e110455-lin.cambridge.arm.com \
--to=liviu.dudau@arm.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).