From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 132CE219FC; Mon, 14 Oct 2024 16:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728923516; cv=none; b=jwv3MZTVgs1/xEkbinyq6Xc0JqXhPsgQD4fJ+ousJoQ6XBFwh3etBFwyIUFsSjVfDeR+xIk2h/RpDKSSXmVAPv7S4D1l31CqRFa2iZz5aVzF5R1lrcVHBylVsK9X3y//nF4PxWNjT4WYPIe2IMypiID3HByWxw1qnZi66KmLbKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728923516; c=relaxed/simple; bh=J4RYJQdbHZ8u/a1Vqi8q8LZYmuKpwmhzcaKo3jaJF0Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r4XBHie9NIDQmOKi5fidbWMsGHiUzHZqkdlercUI9p9oGybtQwqAgMC6+SZ4gSl+MDQrCI/oMEQdSwrlwdHWik0tDtPMPDrMHjZyf+VoASoV4IxfqzU0NzICHOf49KY9c5dWlb6lZKcFtsBDpToCfR8u9WdUbM88LyFdlhCPLLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92EACC4CEC3; Mon, 14 Oct 2024 16:31:49 +0000 (UTC) Date: Mon, 14 Oct 2024 17:31:47 +0100 From: Catalin Marinas To: Marc Zyngier Cc: Nathan Chancellor , Mark Brown , Will Deacon , Jonathan Corbet , Andrew Morton , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , David Spickett , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v13 11/40] arm64/gcs: Provide basic EL2 setup to allow GCS usage at EL0 and EL1 Message-ID: References: <20241001-arm64-gcs-v13-0-222b78d87eee@kernel.org> <20241001-arm64-gcs-v13-11-222b78d87eee@kernel.org> <20241009204903.GA3353168@thelio-3990X> <86msjc56mi.wl-maz@kernel.org> <86h69i6bpy.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86h69i6bpy.wl-maz@kernel.org> On Fri, Oct 11, 2024 at 01:55:05PM +0100, Marc Zyngier wrote: > On Thu, 10 Oct 2024 18:16:52 +0100, > Catalin Marinas wrote: > > > > On Thu, Oct 10, 2024 at 04:18:13PM +0100, Marc Zyngier wrote: > > > From 20c98d2647c11db1e40768f92c5998ff5d764a3a Mon Sep 17 00:00:00 2001 > > > From: Marc Zyngier > > > Date: Thu, 10 Oct 2024 16:13:26 +0100 > > > Subject: [PATCH] KVM: arm64: Shave a few bytes from the EL2 idmap code > > > > > > Our idmap is becoming too big, to the point where it doesn't fit in > > > a 4kB page anymore. > > > > > > There are some low-hanging fruits though, such as the el2_init_state > > > horror that is expanded 3 times in the kernel. Let's at least limit > > > ourselves to two copies, which makes the kernel link again. > > > > > > At some point, we'll have to have a better way of doing this. > > > > > > Reported-by: Nathan Chancellor > > > Signed-off-by: Marc Zyngier > > > Link: https://lore.kernel.org/r/20241009204903.GA3353168@thelio-3990X > > > > Thanks Marc for the quick fix. It looks fine to me, it will keep the > > linker quiet for a while. I pushed it to arm64 for-kernelci for the time > > being, see if anything falls apart. I'll apply it properly once it gets > > a bit more testing. > > Works for me. But if that helps, I can also queue it as a KVM fix for > 6.12, leaving the GCS branch unencumbered. Just let me know. That would help, thanks. The for-kernelci branch merges the latest mainline rc anyway, so it will no longer blow up allmodconfig tests. -- Catalin