Re: [PATCH v1 5/6] memcg-v1: no need for memcg locking for MGLRU

Yu Zhao
2024-10-26T15:26:42Z

On Sat, Oct 26, 2024 at 12:34 AM Shakeel Butt <shakeel.butt@linux.dev> wrote:
>
> On Thu, Oct 24, 2024 at 06:23:02PM GMT, Shakeel Butt wrote:
> > While updating the generation of the folios, MGLRU requires that the
> > folio's memcg association remains stable. With the charge migration
> > deprecated, there is no need for MGLRU to acquire locks to keep the
> > folio and memcg association stable.
> >
> > Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>
>
> Andrew, can you please apply the following fix to this patch after your
> unused fixup?

Thanks!

> index fd7171658b63..b8b0e8fa1332 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -3353,7 +3353,7 @@ static struct folio *get_pfn_folio(unsigned long pfn, struct mem_cgroup *memcg,
> if (folio_nid(folio) != pgdat->node_id)
> return NULL;
>
> - if (folio_memcg_rcu(folio) != memcg)
> + if (folio_memcg(folio) != memcg)
> return NULL;
>
> /* file VMAs can contain anon pages from COW */
>
>