From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9EE01DC739 for ; Tue, 29 Oct 2024 17:53:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730224428; cv=none; b=OpOhppoUjy8m5xn8I1Ek36TeSURbi/hspT1LdEgQjfRHR2lu2KJsoexhBY5uDxn+MFBcTaoOCKzIDydgDKlEPxQ4M5EPhsY83HxwaBYTgKfK0idp05ocSTPxtvE/PoFsil/MRQJAbfHaCK1NHj8w9/T3q/vWd1NK43FTscjxOh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730224428; c=relaxed/simple; bh=WziafT2eTMjBjW229ktOTyL8rO7sTGDiAd1/ejN4CL4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y+UbwPjLo5nZmd7JgMUKdnFUZGPi4c8K5m8PUKB2w3G7cWJOtmOQWSOfOt/yXkDlw0ugD7DacN9qNPlD+8we48KxhC3dZI9ce8vwbvChLfaZ9vBAR5A8HtBDhm1T/FvYQGT5Hvc7mCvBRX/WX/xpvzN5Xx0Bqcyux0zkyiUfIUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=fTJU99wk; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="fTJU99wk" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20c693b68f5so62499805ad.1 for ; Tue, 29 Oct 2024 10:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1730224426; x=1730829226; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=EtH9ZoQPDiHEkDhWLDrz6/hg7ImzZ8y8bzq5j1Y7ZXc=; b=fTJU99wkY+RRoB7XpBbCXXjI/OIxRM6ZKggywcCD1AQ5CkuWr7kIA2cI0s5AbC7PCx xuhVIq/nP7lfy+NqbmQhkHeZVkH+q66Nl1ERPbhAc4SKqzixwiq8/QQHNMS25PoFD7q7 nXEsapYO/X7NwwAU+j3NSg6e9zQxmhcjVOy5M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730224426; x=1730829226; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EtH9ZoQPDiHEkDhWLDrz6/hg7ImzZ8y8bzq5j1Y7ZXc=; b=AxtsgwVH7wACwEhS6DQE4c6x4hfg0PI5r4zogiewjcbYll1l0cZ6iiObrtMyZqc5h5 8ZB7OUH5eah+GkCm9FPPbEoIF72/LF2YnqAC/SBeOIePAP7wP7UeYMurjOrdgGm/Hikt 85C+vGGNH3bWI05uxh+94rr4lmyS2571xsOfqUQFchNz7p9XQhxSGStq/akZxiLM8nnS e6IwNxDtXzCHFRuhMlRCNEW0VurcMfcFAGEm3eFmWgFO72yF7JkFu8GRHlmTUb+O8ccB pF4oNzfSpE9Zn2bxCdJxwwdDhglwIDWyNvbtoZ30Im6oruaYNJx17KCsDJC5veAJJ2Fr /V9A== X-Forwarded-Encrypted: i=1; AJvYcCXhT05JX5rt0qpn39d9qeHq9WwmxOdlGiMSYh4vwa3YX2epCQg6GUgN/Tw2KbstyQfaj8+L45XrbwuO6mGc@vger.kernel.org X-Gm-Message-State: AOJu0Yyu1cK7jjrGQnqGGQhP9+Of1IhQZWq8PQAK2WMl0bLSddd82Lij fidY0UFSw2+SUn/nD4uVfO5q8nlz95XPkE0Xc6kGG7dDWtscZ3iAc9viteZC9OA= X-Google-Smtp-Source: AGHT+IFl0sEy36nL06f5S7GHxaLAmGOVL3UnW1+PfSkmqSMmqC2WV99zVZZGGp1yXDhj/okALP3/GQ== X-Received: by 2002:a17:902:d507:b0:20e:986a:6e72 with SMTP id d9443c01a7336-210c6c0906bmr183390355ad.30.1730224426104; Tue, 29 Oct 2024 10:53:46 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bbf88490sm68819745ad.114.2024.10.29.10.53.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 10:53:45 -0700 (PDT) Date: Tue, 29 Oct 2024 10:53:41 -0700 From: Joe Damato To: Paolo Abeni Cc: netdev@vger.kernel.org, namangulati@google.com, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net, m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, willemdebruijn.kernel@gmail.com, skhawaja@google.com, kuba@kernel.org, Alexander Lobakin , Alexander Viro , "open list:BPF [MISC] :Keyword:(?:b|_)bpf(?:b|_)" , Christian Brauner , "David S. Miller" , Donald Hunter , Jan Kara , Jesper Dangaard Brouer , Jiri Pirko , Johannes Berg , Jonathan Corbet , "open list:DOCUMENTATION" , "open list:FILESYSTEMS (VFS and infrastructure)" , open list , Lorenzo Bianconi , Martin Karsten , Mina Almasry , Sebastian Andrzej Siewior , Xuan Zhuo Subject: Re: [PATCH net-next v2 0/6] Suspend IRQs during application busy periods Message-ID: Mail-Followup-To: Joe Damato , Paolo Abeni , netdev@vger.kernel.org, namangulati@google.com, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net, m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, willemdebruijn.kernel@gmail.com, skhawaja@google.com, kuba@kernel.org, Alexander Lobakin , Alexander Viro , "open list:BPF [MISC] :Keyword:(?:b|_)bpf(?:b|_)" , Christian Brauner , "David S. Miller" , Donald Hunter , Jan Kara , Jesper Dangaard Brouer , Jiri Pirko , Johannes Berg , Jonathan Corbet , "open list:DOCUMENTATION" , "open list:FILESYSTEMS (VFS and infrastructure)" , open list , Lorenzo Bianconi , Martin Karsten , Mina Almasry , Sebastian Andrzej Siewior , Xuan Zhuo References: <20241021015311.95468-1-jdamato@fastly.com> <57a0e1e7-1079-4055-8072-d9105b70103f@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57a0e1e7-1079-4055-8072-d9105b70103f@redhat.com> On Tue, Oct 29, 2024 at 11:25:18AM +0100, Paolo Abeni wrote: > On 10/21/24 03:52, Joe Damato wrote: [...] > > The changes makes sense to me, and I could not find any obvious issue in > the patches. > > I think this deserve some - even basic - self-tests coverage. Note that > you can enable GRO on veth devices to make NAPI instances avail there. > > Possibly you could opt for a drivers/net defaulting to veth usage and > allowing the user to select real H/W via env variables. Sorry, Paolo, but I took a cursory look at veth and I need to object more strongly to your feedback here. My understanding (which could be incorrect) is that neither veth nor netdevsim use IRQs. The whole purpose of this series is to block IRQs while data is being busy polled to increase efficiency. That's in the cover letter. If neither of the drivers we'd use to simulate this in selftest use IRQs, how could we build a selftest which ensures IRQs are correctly suspended during busy periods without first making considerable changes to either (or both?) drivers? Respectfully: I don't think it's appropriate to block this series on that much additional work. Please reconsider and let me know how to proceed.