From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5075DEB64DC for ; Mon, 3 Jul 2023 10:46:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230131AbjGCKqj (ORCPT ); Mon, 3 Jul 2023 06:46:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbjGCKqh (ORCPT ); Mon, 3 Jul 2023 06:46:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D6F1C1; Mon, 3 Jul 2023 03:46:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 27C8160ECB; Mon, 3 Jul 2023 10:46:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEB8FC433C8; Mon, 3 Jul 2023 10:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688381195; bh=P4r6NcApOev+4x7YkeUxdZOKWi3NhhisX0lwFXTOo/4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=IsIEcv4FjD+BQuWxXXnK+JejhhKL23ugCykdI/hz93XGRHT6Ir8lRp4rO9NsTh8jn ZcDDD5sZUKOtHPxL/2UT4JjuiZMGZBB8ErTZQy8turRd9x3w8rHYLdo3BBIssvHiN0 9LHuvzb12eCSWH4EHLfy8dt3AynandZgVjwei6eCRr7WXdFQcRfA6AESNBbqieKDdr R1bmxI6J6ydN2DbZRZKOlwFqXNKaShx99SFKFe/LS+sB3GpM40OiR59y5/toJ4uS7L IsOHKZB0S1C9boiDOqI1IBqyEHbL57w70XmmfmFnPgmU4Z7ZpnT+lnUshXBIUVGZKk A+zFByhDpf1PQ== Message-ID: Subject: Re: [PATCH 15/79] bfs: switch to new ctime accessors From: Jeff Layton To: Christian Brauner Cc: Kara , "Tigran A. Aivazian" , Al Viro , linux-kernel@vger.kernel.org, "damien.lemoal" , linux-fsdevel@vger.kernel.org Date: Mon, 03 Jul 2023 06:46:33 -0400 In-Reply-To: <20230703-gebucht-improvisieren-6c9b66612f07@brauner> References: <20230621144507.55591-1-jlayton@kernel.org> <20230621144735.55953-1-jlayton@kernel.org> <20230621144735.55953-14-jlayton@kernel.org> <20230621164808.5lhujni7qb36hhtk@quack3> <646b7283ede4945b335ad16aea5ff60e1361241e.camel@kernel.org> <20230622123050.thpf7qdnmidq3thj@quack3> <20230622145747.lokguccxtrrpgb3b@quack3> <20230623-kaffee-volumen-014cfa91a2ee@brauner> <20230703-gebucht-improvisieren-6c9b66612f07@brauner> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, 2023-07-03 at 12:12 +0200, Christian Brauner wrote: > On Fri, Jun 23, 2023 at 02:33:26PM +0200, Christian Brauner wrote: > > On Thu, Jun 22, 2023 at 04:57:47PM +0200, Jan Kara wrote: > > > On Thu 22-06-23 08:51:58, Jeff Layton wrote: > > > > On Thu, 2023-06-22 at 14:30 +0200, Jan Kara wrote: > > > > > On Wed 21-06-23 12:57:19, Jeff Layton wrote: > > > > > > On Wed, 2023-06-21 at 18:48 +0200, Jan Kara wrote: > > > > > > > On Wed 21-06-23 10:45:28, Jeff Layton wrote: > > > > > > > > In later patches, we're going to change how the ctime.tv_ns= ec field is > > > > > > > > utilized. Switch to using accessor functions instead of raw= accesses of > > > > > > > > inode->i_ctime. > > > > > > > >=20 > > > > > > > > Signed-off-by: Jeff Layton > > > > > > >=20 > > > > > > > ... > > > > > > >=20 > > > > > > > > diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c > > > > > > > > index 1926bec2c850..c964316be32b 100644 > > > > > > > > --- a/fs/bfs/inode.c > > > > > > > > +++ b/fs/bfs/inode.c > > > > > > > > @@ -82,10 +82,10 @@ struct inode *bfs_iget(struct super_blo= ck *sb, unsigned long ino) > > > > > > > > inode->i_blocks =3D BFS_FILEBLOCKS(di); > > > > > > > > inode->i_atime.tv_sec =3D le32_to_cpu(di->i_atime); > > > > > > > > inode->i_mtime.tv_sec =3D le32_to_cpu(di->i_mtime); > > > > > > > > - inode->i_ctime.tv_sec =3D le32_to_cpu(di->i_ctime); > > > > > > > > + inode_ctime_set_sec(inode, le32_to_cpu(di->i_ctime)); > > > > > > > > inode->i_atime.tv_nsec =3D 0; > > > > > > > > inode->i_mtime.tv_nsec =3D 0; > > > > > > > > - inode->i_ctime.tv_nsec =3D 0; > > > > > > > > + inode_ctime_set_nsec(inode, 0); > > > > > > >=20 > > > > > > > So I'm somewhat wondering here - in other filesystem you cons= truct > > > > > > > timespec64 and then use inode_ctime_set(). Here you use > > > > > > > inode_ctime_set_sec() + inode_ctime_set_nsec(). What's the be= nefit? It > > > > > > > seems these two functions are not used that much some maybe w= e could just > > > > > > > live with just inode_ctime_set() and constructing timespec64 = when needed? > > > > > > >=20 > > > > > > > Honza > > > > > >=20 > > > > > > The main advantage is that by using that, I didn't need to do q= uite so > > > > > > much of this conversion by hand. My coccinelle skills are prett= y > > > > > > primitive. I went with whatever conversion was going to give mi= nimal > > > > > > changes, to the existing accesses for the most part. > > > > > >=20 > > > > > > We could certainly do it the way you suggest, it just means hav= ing to > > > > > > re-touch a lot of this code by hand, or someone with better coc= cinelle > > > > > > chops suggesting a way to declare a temporary variables in plac= e. > > > > >=20 > > > > > Well, maybe temporary variables aren't that convenient but we cou= ld provide > > > > > function setting ctime from sec & nsec value without having to de= clare > > > > > temporary timespec64? Attached is a semantic patch that should de= al with > > > > > that - at least it seems to handle all the cases I've found. > > > > >=20 > > > >=20 > > > > Ok, let me try respinning this with your cocci script and see how i= t > > > > looks. > > > >=20 > > > > Damien also suggested in a reply to the zonefs patch a preference f= or > > > > the naming style you have above. Should I also rename these like? > > > >=20 > > > > inode_ctime_peek -> inode_get_ctime > > > > inode_ctime_set -> inode_set_ctime > > > >=20 > > > > This would be the time to change it if that's preferred. > > >=20 > > > I don't really care much so whatever you decide is better :) > >=20 > > I have a mild preference for inode_{get,set}_ctime(). >=20 > Jeff, did you plan on sending a v2 with this renamed or do you want me > to pick this up now? I'm working on a new set that I'll send out in a few days. Sorry it has taken a while, I spent quite a bit of time trying to improve my coccinelle chops for this. Thanks, --=20 Jeff Layton