From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5445A2EB87E for ; Tue, 4 Nov 2025 12:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762257898; cv=none; b=A9bgjQFBkBOIsipcp41fzpQ/pnf1FQ7pFEkjCWOBw+VOfGiMRac4/654nnTUfk6FEGSGFKT82V2ctGmkHJ7Y6O28hZlNykkrzrQID7NiTQ8j7h04KIZkuM6mfY6yy+JQObSZRb5uop8G2lRmh+zBizVjPhHm9m5nE81BKWI/NY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762257898; c=relaxed/simple; bh=91j83r0a/744GsjSSpvMj2vPPbbmwRCLqH0NKKKQxTs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:Mime-Version; b=K8/octdNImSsRwmFjvmz95LciYZnwqM5ztiviKvLT8YuSNjha1wtSiWZU/CsHb3PzDRIqg6qMIoPEIpjqQWC2deb8ba490X8Ealtrn6e2rmYkpPj+cgdvsEtxVEUg3x14989uxAe5oDiptxzFoDb6yPSlnPF8TZcFDRuS3rE+Sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VfPVlvIU; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VfPVlvIU" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-29524abfba3so40685415ad.1 for ; Tue, 04 Nov 2025 04:04:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762257897; x=1762862697; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to:date :cc:to:from:subject:message-id:from:to:cc:subject:date:message-id :reply-to; bh=hIMOgpEtwvgPznTb3R/noQ8H3QESHZcJ3b2FNe/UuI0=; b=VfPVlvIUyTV8qIihY9JjSsKeyNBWMl6UMFmRHCYWXD/joLcLMadxUuigePc7OhaZrY poj39NwZlF7+axyTDmSBJZ4OAlWaIr7WNFIwvrpEi3HxnWPGVIBY+gLnWoFBRlDDThYl j5zBzjXV9t/sahOazDTvFdKATZUWOqVN1tY2AzxYG1MId0HMuxoSEe2F6b82KB1ne/h+ LEDmMa4nPJ6uRvAYKezrrO6KUc7QMaqhzHqVkUS40HQUtiFYcPk+XmZH/a9FvXU2/hf4 6a80ov5PHP2a0+LlvS8un7oaNXSNfvizKWZKs7QCnHqx/okdk249o3XS+QCDKsBfTnTM /yXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762257897; x=1762862697; h=content-transfer-encoding:mime-version:references:in-reply-to:date :cc:to:from:subject:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hIMOgpEtwvgPznTb3R/noQ8H3QESHZcJ3b2FNe/UuI0=; b=uDSAArwTA0jAqaLXynFgPu0Jm+8Yn4pw3rhgkbIS6mvpg7NDFYIwFCsoXL0gof+wl4 RcA8uDbKRyhqiE+vC3oz61lq1eCoTkZUilJXtMSCHzF+RAFOlesR57L6EKg+pYxhFwis yJp99OFW1kTG72BEPEydVqr2/2c5fT1XwG7vnf1KWx+QIpCoOgtLI3GWRtc8rVe+VPlM 2Ymdoj2iXk/yLQD2GnXYNgcItxn8zXlV4+Kx2vS9kO5NZ3eltTqfnOmsF59Ut8zmqlSj Yda0pUJSOhCtiBRHhdXYsO3fovCjEmZD/1QlKM6F5egkbJCOCePEXpe2W3M+u0hl43z0 wVlw== X-Forwarded-Encrypted: i=1; AJvYcCXGW9r75IVGrNgVRN7Hwr8D1A7qabNrXmzgsxVHtrBvaK7ThnwZ02fNflvqH/k6kVfyhVeK7fmF6Lf2OrU0@vger.kernel.org X-Gm-Message-State: AOJu0YxFHF3sg5NKYio2vzrTLREnRx6ZpqGIx7w+3JXgoVEI6wCZZ3gb 9b26FMnAIoryzV7Vlwo2ASpEblcMopCUQuellzD6dLC7LrJPjBoWtiL7 X-Gm-Gg: ASbGncvMPy3g4S0hXgFVk3Q4iPE+9rOuZ/N5kzei11kkNW7l7W4b1MMyetncxaHKBYg yl/kXbrExrbRjSBtow+4PbbLzfWng0Nyn05PTrZjpIDL0+DgcYc1I8cjowzUwWkaAfT2O8saHfI 4yrlmq+KmH1B/7JwcK2tmZbguvnfRfRM9/ewYmbIRATQdH8rmTfoJFtHcE0u7TJ2xK8pjg6x8dL CG+Bjl/+3pat6Kc/mW/0Z6kFDsP4jcaoaUeTaTZBjrX1T3L5h+gjvuI7oCBRSuTze5n+fwcXTbU h1mbwVdvKLixOLa6RX0mPGPoYvYpoIi7pooIAAkThdAemuYrurUOU4OV2tbOmzmB74nlLyKg1AB FccWnG9DXqId503jlX9QyUWS8K1gDbGoNcgWyuh2UPzofH9vIWVJcmICXRducSsYr2wK+6L0zNX VhNkkxgL4ssRsD5txeQLSt6P/uNYR4JkTLuAI1LhBVfl5IdLsrj2icxQ== X-Google-Smtp-Source: AGHT+IHhptMGeN6GUWdSr3woSCYhxUw05Wn9RRD4O2T5DayZS0jhPNbaRMV4ZHTfd4sd7Ew85mCkaw== X-Received: by 2002:a17:902:e88e:b0:295:fe33:18bb with SMTP id d9443c01a7336-295fe331993mr38565105ad.14.1762257896410; Tue, 04 Nov 2025 04:04:56 -0800 (PST) Received: from li-5d80d4cc-2782-11b2-a85c-bed59fe4c9e5.ibm.com ([49.207.200.106]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2960199831esm24707045ad.37.2025.11.04.04.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Nov 2025 04:04:55 -0800 (PST) Message-ID: Subject: Re: [PATCH 2/4] fs: return writeback errors for IOCB_DONTCACHE in generic_write_sync From: "Nirjhar Roy (IBM)" To: Christoph Hellwig , "Darrick J. Wong" Cc: Carlos Maiolino , Christian Brauner , Jan Kara , "Martin K. Petersen" , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org Date: Tue, 04 Nov 2025 17:34:50 +0530 In-Reply-To: <20251029163708.GC26985@lst.de> References: <20251029071537.1127397-1-hch@lst.de> <20251029071537.1127397-3-hch@lst.de> <20251029160101.GE3356773@frogsfrogsfrogs> <20251029163708.GC26985@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-27.el8_10) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit On Wed, 2025-10-29 at 17:37 +0100, Christoph Hellwig wrote: > On Wed, Oct 29, 2025 at 09:01:01AM -0700, Darrick J. Wong wrote: > > Hum. So we kick writeback but don't wait for any of it to start, and > > immediately sample wberr. Does that mean that in the "bdev died" case, > > the newly initiated writeback will have failed so quickly that > > file_check_and_advance_wb_err will see that? > > Yes, this is primarily about catching errors in the submission path > before it reaches the device, which are returned synchronously. So, what you are saying is file_check_and_advance_wb_err() will wait/block till the write back request done in filemap_fdatawrite_range_kick() is completely submitted and there are no more chances of write back failure? --NR > > > Or are we only reflecting > > past write failures back to userspace on the *second* write after the > > device dies? > > > > It would be helpful to know which fstests break, btw. > > generic/252 generic/329 xfs/237 >