From: Randy Dunlap <rdunlap@infradead.org>
To: Yang Li <yang.lee@linux.alibaba.com>, viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] fs/kernel_read_file: Fix some kernel-doc comments
Date: Tue, 16 Aug 2022 15:47:45 -0700 [thread overview]
Message-ID: <a063c19e-f6b9-a7ae-a199-1fc60de01c21@infradead.org> (raw)
In-Reply-To: <20220815054411.68818-1-yang.lee@linux.alibaba.com>
On 8/14/22 22:44, Yang Li wrote:
> Add a colon between the parameter name and description to meet the
> scripts/kernel-doc.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1901
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> fs/kernel_read_file.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/kernel_read_file.c b/fs/kernel_read_file.c
> index 5d826274570c..c4fc84e6d099 100644
> --- a/fs/kernel_read_file.c
> +++ b/fs/kernel_read_file.c
> @@ -8,16 +8,16 @@
> /**
> * kernel_read_file() - read file contents into a kernel buffer
> *
> - * @file file to read from
> - * @offset where to start reading from (see below).
> - * @buf pointer to a "void *" buffer for reading into (if
> + * @file: file to read from
> + * @offset: where to start reading from (see below).
> + * @buf: pointer to a "void *" buffer for reading into (if
> * *@buf is NULL, a buffer will be allocated, and
> * @buf_size will be ignored)
> - * @buf_size size of buf, if already allocated. If @buf not
> + * @buf_size: size of buf, if already allocated. If @buf not
> * allocated, this is the largest size to allocate.
> - * @file_size if non-NULL, the full size of @file will be
> + * @file_size: if non-NULL, the full size of @file will be
> * written here.
> - * @id the kernel_read_file_id identifying the type of
> + * @id: the kernel_read_file_id identifying the type of
> * file contents being read (for LSMs to examine)
> *
> * @offset must be 0 unless both @buf and @file_size are non-NULL
--
~Randy
prev parent reply other threads:[~2022-08-16 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 5:44 [PATCH -next] fs/kernel_read_file: Fix some kernel-doc comments Yang Li
2022-08-16 22:47 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a063c19e-f6b9-a7ae-a199-1fc60de01c21@infradead.org \
--to=rdunlap@infradead.org \
--cc=abaci@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).