From: Jens Axboe <axboe@kernel.dk>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hannes@cmpxchg.org
Subject: Re: [PATCH 1/2] writeback: eliminate work item allocation in bd_start_writeback()
Date: Wed, 4 Oct 2017 08:42:12 -0600 [thread overview]
Message-ID: <a139134d-0e65-fac4-1c77-22fb729cadf6@kernel.dk> (raw)
In-Reply-To: <20171004072635.GP11879@quack2.suse.cz>
On 10/04/2017 01:26 AM, Jan Kara wrote:
>> diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h
>> index 420de5c7c7f9..f0f1df29d6b8 100644
>> --- a/include/linux/backing-dev-defs.h
>> +++ b/include/linux/backing-dev-defs.h
>> @@ -116,6 +116,7 @@ struct bdi_writeback {
>>
>> struct fprop_local_percpu completions;
>> int dirty_exceeded;
>> + int start_all_reason;
>
> This should be 'enum wb_reason' instead of 'int'.
Yes good point, I'll move the enum and change 'start_all_reason' to be
of type enum wb_reason.
Thanks for the review!
--
Jens Axboe
next prev parent reply other threads:[~2017-10-04 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 15:16 [PATCH 0/2] writeback: start-all allocation elimination Jens Axboe
2017-10-03 15:16 ` [PATCH 1/2] writeback: eliminate work item allocation in bd_start_writeback() Jens Axboe
2017-10-04 7:26 ` Jan Kara
2017-10-04 14:42 ` Jens Axboe [this message]
2017-10-03 15:16 ` [PATCH 2/2] sysctl: remove /proc/sys/vm/nr_pdflush_threads Jens Axboe
2017-10-04 7:20 ` Jan Kara
2017-10-06 13:49 ` Rakesh Pandit
2017-10-06 14:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a139134d-0e65-fac4-1c77-22fb729cadf6@kernel.dk \
--to=axboe@kernel.dk \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).