From: Bagas Sanjaya <bagasdotme@gmail.com>
To: "Hok Chun NG (Ben)" <me@benbenng.net>
Cc: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>
Subject: Re: [PATCH] Update documentation of vfs_tmpfile
Date: Wed, 22 Feb 2023 09:32:54 +0700 [thread overview]
Message-ID: <a1635643-a4a8-61e1-7798-af7455668878@gmail.com> (raw)
In-Reply-To: <0100018676b0882f-5895463a-0af2-4fae-9e0b-8d4676347b1f-000000@email.amazonses.com>
On 2/22/23 08:15, Hok Chun NG (Ben) wrote:
> Hi Bagas,
>
>> On Feb 21, 2023, at 8:21 AM, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>>
>> On Tue, Feb 21, 2023 at 03:55:54AM +0000, Hok Chun NG (Ben) wrote:
>>> On function vfs_tmpfile, documentation is updated according to function signature update.
>>>
>>> Description for 'dentry' and 'open_flag' removed.
>>> Description for 'parentpath' and 'file' added.
>>
>> What commit did vfs_tmpfile() change its signature?
>
> Changes of the function signature is from 9751b338656f05a0ce918befd5118fcd970c71c6
> vfs: move open right after ->tmpfile() by Miklos Szeredi mszeredi@redhat.com
>
Nice.
The preferred git pretty format when referring to existing commit is
"%h (\"%s\")". Make sure that you set core.abbrev to at least 12.
>>
>> For the patch description, I'd like to write "Commit <commit> changes
>> function signature for vfs_tmpfile(). Catch the function documentation
>> up with the change."
>
> I agree. Thank you for the suggestion.
>
OK, thanks!
--
An old man doll... just what I always wanted! - Clara
prev parent reply other threads:[~2023-02-22 2:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230221035528.10529-1-me@benbenng.net>
2023-02-21 3:55 ` [PATCH] Update documentation of vfs_tmpfile Hok Chun NG (Ben)
2023-02-21 13:21 ` Bagas Sanjaya
[not found] ` <346A4D50-E68E-4D03-B06B-4949F5640197@benbenng.net>
2023-02-22 1:15 ` Hok Chun NG (Ben)
2023-02-22 2:32 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1635643-a4a8-61e1-7798-af7455668878@gmail.com \
--to=bagasdotme@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@benbenng.net \
--cc=skhan@linuxfoundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).