* [PATCH] Update documentation of vfs_tmpfile [not found] <20230221035528.10529-1-me@benbenng.net> @ 2023-02-21 3:55 ` Hok Chun NG (Ben) 2023-02-21 13:21 ` Bagas Sanjaya 0 siblings, 1 reply; 4+ messages in thread From: Hok Chun NG (Ben) @ 2023-02-21 3:55 UTC (permalink / raw) To: viro@zeniv.linux.org.uk Cc: Hok Chun NG (Ben), linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org On function vfs_tmpfile, documentation is updated according to function signature update. Description for 'dentry' and 'open_flag' removed. Description for 'parentpath' and 'file' added. Signed-off-by: Ben Hok-Chun NG <me@benbenng.net> --- fs/namei.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 309ae6fc8c99..21261163d6d3 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3571,9 +3571,9 @@ static int do_open(struct nameidata *nd, /** * vfs_tmpfile - create tmpfile * @mnt_userns: user namespace of the mount the inode was found from - * @dentry: pointer to dentry of the base directory + * @parentpath: path to the base directory + * @file: pointer to the file struct of the new tmpfile * @mode: mode of the new tmpfile - * @open_flag: flags * * Create a temporary file. * -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Update documentation of vfs_tmpfile 2023-02-21 3:55 ` [PATCH] Update documentation of vfs_tmpfile Hok Chun NG (Ben) @ 2023-02-21 13:21 ` Bagas Sanjaya [not found] ` <346A4D50-E68E-4D03-B06B-4949F5640197@benbenng.net> 0 siblings, 1 reply; 4+ messages in thread From: Bagas Sanjaya @ 2023-02-21 13:21 UTC (permalink / raw) To: Hok Chun NG (Ben), viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org [-- Attachment #1: Type: text/plain, Size: 563 bytes --] On Tue, Feb 21, 2023 at 03:55:54AM +0000, Hok Chun NG (Ben) wrote: > On function vfs_tmpfile, documentation is updated according to function signature update. > > Description for 'dentry' and 'open_flag' removed. > Description for 'parentpath' and 'file' added. What commit did vfs_tmpfile() change its signature? For the patch description, I'd like to write "Commit <commit> changes function signature for vfs_tmpfile(). Catch the function documentation up with the change." Thanks. -- An old man doll... just what I always wanted! - Clara [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <346A4D50-E68E-4D03-B06B-4949F5640197@benbenng.net>]
* Re: [PATCH] Update documentation of vfs_tmpfile [not found] ` <346A4D50-E68E-4D03-B06B-4949F5640197@benbenng.net> @ 2023-02-22 1:15 ` Hok Chun NG (Ben) 2023-02-22 2:32 ` Bagas Sanjaya 0 siblings, 1 reply; 4+ messages in thread From: Hok Chun NG (Ben) @ 2023-02-22 1:15 UTC (permalink / raw) To: Bagas Sanjaya Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org Hi Bagas, > On Feb 21, 2023, at 8:21 AM, Bagas Sanjaya <bagasdotme@gmail.com> wrote: > > On Tue, Feb 21, 2023 at 03:55:54AM +0000, Hok Chun NG (Ben) wrote: >> On function vfs_tmpfile, documentation is updated according to function signature update. >> >> Description for 'dentry' and 'open_flag' removed. >> Description for 'parentpath' and 'file' added. > > What commit did vfs_tmpfile() change its signature? Changes of the function signature is from 9751b338656f05a0ce918befd5118fcd970c71c6 vfs: move open right after ->tmpfile() by Miklos Szeredi mszeredi@redhat.com > > For the patch description, I'd like to write "Commit <commit> changes > function signature for vfs_tmpfile(). Catch the function documentation > up with the change." I agree. Thank you for the suggestion. > > Thanks. > > -- > An old man doll... just what I always wanted! - Clara Best, Ben ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Update documentation of vfs_tmpfile 2023-02-22 1:15 ` Hok Chun NG (Ben) @ 2023-02-22 2:32 ` Bagas Sanjaya 0 siblings, 0 replies; 4+ messages in thread From: Bagas Sanjaya @ 2023-02-22 2:32 UTC (permalink / raw) To: Hok Chun NG (Ben) Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org On 2/22/23 08:15, Hok Chun NG (Ben) wrote: > Hi Bagas, > >> On Feb 21, 2023, at 8:21 AM, Bagas Sanjaya <bagasdotme@gmail.com> wrote: >> >> On Tue, Feb 21, 2023 at 03:55:54AM +0000, Hok Chun NG (Ben) wrote: >>> On function vfs_tmpfile, documentation is updated according to function signature update. >>> >>> Description for 'dentry' and 'open_flag' removed. >>> Description for 'parentpath' and 'file' added. >> >> What commit did vfs_tmpfile() change its signature? > > Changes of the function signature is from 9751b338656f05a0ce918befd5118fcd970c71c6 > vfs: move open right after ->tmpfile() by Miklos Szeredi mszeredi@redhat.com > Nice. The preferred git pretty format when referring to existing commit is "%h (\"%s\")". Make sure that you set core.abbrev to at least 12. >> >> For the patch description, I'd like to write "Commit <commit> changes >> function signature for vfs_tmpfile(). Catch the function documentation >> up with the change." > > I agree. Thank you for the suggestion. > OK, thanks! -- An old man doll... just what I always wanted! - Clara ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-22 2:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230221035528.10529-1-me@benbenng.net>
2023-02-21 3:55 ` [PATCH] Update documentation of vfs_tmpfile Hok Chun NG (Ben)
2023-02-21 13:21 ` Bagas Sanjaya
[not found] ` <346A4D50-E68E-4D03-B06B-4949F5640197@benbenng.net>
2023-02-22 1:15 ` Hok Chun NG (Ben)
2023-02-22 2:32 ` Bagas Sanjaya
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).