From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C0BC83005 for ; Wed, 7 Jun 2023 12:29:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240919AbjFGM3O (ORCPT ); Wed, 7 Jun 2023 08:29:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240896AbjFGM3L (ORCPT ); Wed, 7 Jun 2023 08:29:11 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19E191BDA; Wed, 7 Jun 2023 05:29:09 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9B91C219E0; Wed, 7 Jun 2023 12:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686140947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+NXFD7tK19U/km1dvM1TqrNDaxi8TnBZKN3pwKYh7bg=; b=D+bVusfixROdFRhZj7Gm32vf6nTWDMSSzJfTRi50B/2LNNRitehn0JGhZsGotTAyYt87Bx NWYyvr9Ov4qnxE9QA80piLbIwqsP6xLCWfFFOEfdtYTV7w8CCMXeEmox8sfL1yHMjHzwBw 89mLO0+2N8iDZa/tZ7q2dCVCM1RS6Qs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686140947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+NXFD7tK19U/km1dvM1TqrNDaxi8TnBZKN3pwKYh7bg=; b=kIiNhRufIqKqREi/FFsC6HuCVpqDds10Ql5+QSsqZIqvjGBGRBJM3qVyYeDSJ+qeyfv1Ec jELBtRQvTWOS0fCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 520DB13776; Wed, 7 Jun 2023 12:29:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cBHGEhN4gGTwRQAAMHmgww (envelope-from ); Wed, 07 Jun 2023 12:29:07 +0000 Message-ID: Date: Wed, 7 Jun 2023 14:29:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 16/31] block: use the holder as indication for exclusive opens Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-17-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230606073950.225178-17-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 6/6/23 09:39, Christoph Hellwig wrote: > The current interface for exclusive opens is rather confusing as it > requires both the FMODE_EXCL flag and a holder. Remove the need to pass > FMODE_EXCL and just key off the exclusive open off a non-NULL holder. > > For blkdev_put this requires adding the holder argument, which provides > better debug checking that only the holder actually releases the hold, > but at the same time allows removing the now superfluous mode argument. > > Signed-off-by: Christoph Hellwig > --- > block/bdev.c | 37 ++++++++++++++++------------ > block/fops.c | 6 +++-- > block/genhd.c | 5 ++-- > block/ioctl.c | 5 ++-- > drivers/block/drbd/drbd_nl.c | 23 ++++++++++------- > drivers/block/pktcdvd.c | 13 +++++----- > drivers/block/rnbd/rnbd-srv.c | 4 +-- > drivers/block/xen-blkback/xenbus.c | 2 +- > drivers/block/zram/zram_drv.c | 8 +++--- > drivers/md/bcache/super.c | 15 ++++++------ > drivers/md/dm.c | 6 ++--- > drivers/md/md.c | 38 +++++++++++++++-------------- > drivers/mtd/devices/block2mtd.c | 4 +-- > drivers/nvme/target/io-cmd-bdev.c | 2 +- > drivers/s390/block/dasd_genhd.c | 2 +- > drivers/target/target_core_iblock.c | 6 ++--- > drivers/target/target_core_pscsi.c | 8 +++--- > fs/btrfs/dev-replace.c | 6 ++--- > fs/btrfs/ioctl.c | 12 ++++----- > fs/btrfs/volumes.c | 28 ++++++++++----------- > fs/btrfs/volumes.h | 6 ++--- > fs/erofs/super.c | 7 +++--- > fs/ext4/super.c | 11 +++------ > fs/f2fs/super.c | 2 +- > fs/jfs/jfs_logmgr.c | 6 ++--- > fs/nfs/blocklayout/dev.c | 4 +-- > fs/nilfs2/super.c | 6 ++--- > fs/ocfs2/cluster/heartbeat.c | 4 +-- > fs/reiserfs/journal.c | 19 +++++++-------- > fs/reiserfs/reiserfs.h | 1 - > fs/super.c | 20 +++++++-------- > fs/xfs/xfs_super.c | 15 ++++++------ > include/linux/blkdev.h | 2 +- > kernel/power/hibernate.c | 12 +++------ > kernel/power/power.h | 2 +- > kernel/power/swap.c | 21 +++++++--------- > mm/swapfile.c | 7 +++--- > 37 files changed, 183 insertions(+), 192 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes