From: Markus Elfring <Markus.Elfring@web.de>
To: David Howells <dhowells@redhat.com>,
linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org
Cc: Zhihao Cheng <chengzhihao1@huawei.com>,
Yi Zhang <yi.zhang@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [v2] afs: Fix memory leak in afs_put_sysnames()
Date: Mon, 1 Jun 2020 20:04:50 +0200 [thread overview]
Message-ID: <a28fd20e-1f9e-d070-4d2e-2bee89f39154@web.de> (raw)
In-Reply-To: <1346217.1591031323@warthog.procyon.org.uk>
> Perhaps something like:
>
> Fix afs_put_sysnames() to actually free the specified afs_sysnames
> object after its reference count has been decreased to zero and its
> contents have been released.
* How do you think about to omit the word "Fix" because of the provided tag?
* Is freeing and releasing an item a duplicate operation anyhow?
>> Will it matter to mention the size of the data structure "afs_sysnames"?
>
> Why is it necessary to do so?
I suggest to express the impact of the missed function call "kfree".
Regards,
Markus
next prev parent reply other threads:[~2020-06-01 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 14:40 [PATCH v2] afs: Fix memory leak in afs_put_sysnames() Markus Elfring
2020-06-01 17:08 ` David Howells
2020-06-01 18:04 ` Markus Elfring [this message]
2020-06-01 18:52 ` [v2] " David Howells
2020-06-02 5:51 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a28fd20e-1f9e-d070-4d2e-2bee89f39154@web.de \
--to=markus.elfring@web.de \
--cc=chengzhihao1@huawei.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).