From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ulrich Drepper" Subject: Re: [RFC/PATCH] revoke/frevoke system calls V2 Date: Thu, 27 Jul 2006 09:41:30 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@osdl.org, viro@zeniv.linux.org.uk, alan@lxorguk.ukuu.org.uk, tytso@mit.edu, tigran@veritas.com Return-path: Received: from ug-out-1314.google.com ([66.249.92.168]:4199 "EHLO ug-out-1314.google.com") by vger.kernel.org with ESMTP id S1751513AbWG0Qlc (ORCPT ); Thu, 27 Jul 2006 12:41:32 -0400 Received: by ug-out-1314.google.com with SMTP id m3so363464ugc for ; Thu, 27 Jul 2006 09:41:31 -0700 (PDT) To: "Pekka J Enberg" In-Reply-To: Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 7/27/06, Pekka J Enberg wrote: > +asmlinkage int sys_revoke(const char __user *filename) Could we just plainly avoid adding any new syscalls which take a filename without extending the interface like the *at functions? I.e., add a file descriptor parameter, handle AT_FDCWD, etc. The additional effort is really minimal. Even if, as in this case, the function is propably not used in situations where the filename use is racy there are still those people to consider who want to implement a virtual per-thread current working directory.