From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23B28C433E2 for ; Sun, 6 Sep 2020 07:02:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E36FB20714 for ; Sun, 6 Sep 2020 07:02:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725997AbgIFHCI (ORCPT ); Sun, 6 Sep 2020 03:02:08 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:30403 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbgIFHCF (ORCPT ); Sun, 6 Sep 2020 03:02:05 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4Bkj5N0dkTz9v277; Sun, 6 Sep 2020 09:02:00 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 32ZSfig6NQFG; Sun, 6 Sep 2020 09:02:00 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4Bkj5M63jPz9v276; Sun, 6 Sep 2020 09:01:59 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D69238B770; Sun, 6 Sep 2020 09:02:02 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id lMkaToUqP5GL; Sun, 6 Sep 2020 09:02:02 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 6D41C8B75B; Sun, 6 Sep 2020 09:02:02 +0200 (CEST) Subject: Re: [PATCH -next] powerpc/eeh: fix compile warning with CONFIG_PROC_FS=n To: Yang Yingliang , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-fsdevel , Alexey Dobriyan Cc: oohall@gmail.com References: <20200905111749.3198998-1-yangyingliang@huawei.com> From: Christophe Leroy Message-ID: Date: Sun, 6 Sep 2020 09:01:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200905111749.3198998-1-yangyingliang@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Le 05/09/2020 à 13:17, Yang Yingliang a écrit : > Fix the compile warning: > > arch/powerpc/kernel/eeh.c:1639:12: error: 'proc_eeh_show' defined but not used [-Werror=unused-function] > static int proc_eeh_show(struct seq_file *m, void *v) > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > arch/powerpc/kernel/eeh.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c > index 94682382fc8c..420c3c25c6e7 100644 > --- a/arch/powerpc/kernel/eeh.c > +++ b/arch/powerpc/kernel/eeh.c > @@ -1636,6 +1636,7 @@ int eeh_pe_inject_err(struct eeh_pe *pe, int type, int func, > } > EXPORT_SYMBOL_GPL(eeh_pe_inject_err); > > +#ifdef CONFIG_PROC_FS I don't like this way of fixing the issue, because you'll get an unbalanced source code: proc_eeh_show() is apparently referenced all the time in eeh_init_proc(), but because proc_create_single() is a NULL macro when CONFIG_PROC_FS is not selected, you get the 'unused function' error. I think the right fix should be to rewrite proc_create_single() as a static inline function that calls proc_create_single_data() when CONFIG_PROC_FS is selected and just returns NULL otherwise. > static int proc_eeh_show(struct seq_file *m, void *v) > { > if (!eeh_enabled()) { > @@ -1662,6 +1663,7 @@ static int proc_eeh_show(struct seq_file *m, void *v) > > return 0; > } > +#endif > > #ifdef CONFIG_DEBUG_FS > static int eeh_enable_dbgfs_set(void *data, u64 val) > Christophe