[PATCH] statmount: update STATMOUNT_SUPPORTED macro

[PATCH] statmount: update STATMOUNT_SUPPORTED macro

[Dmitry V. Levin]

According to commit 8f6116b5b77b ("statmount: add a new supported_mask
field"), STATMOUNT_SUPPORTED macro shall be updated whenever a new flag
is added.

Fixes: 7a54947e727b ("Merge patch series "fs: allow changing idmappings"")
Signed-off-by: Dmitry V. Levin <ldv@strace.io>
---
 fs/namespace.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index 1b466c54a357..e321f8bae914 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -5804,7 +5804,9 @@ static int grab_requested_root(struct mnt_namespace *ns, struct path *root)
 			     STATMOUNT_SB_SOURCE | \
 			     STATMOUNT_OPT_ARRAY | \
 			     STATMOUNT_OPT_SEC_ARRAY | \
-			     STATMOUNT_SUPPORTED_MASK)
+			     STATMOUNT_SUPPORTED_MASK | \
+			     STATMOUNT_MNT_UIDMAP | \
+			     STATMOUNT_MNT_GIDMAP)
 
 static int do_statmount(struct kstatmount *s, u64 mnt_id, u64 mnt_ns_id,
 			struct mnt_namespace *ns)
-- 
ldv

Re: [PATCH] statmount: update STATMOUNT_SUPPORTED macro

[Christian Brauner]

On Mon, 12 May 2025 01:49:53 +0300, Dmitry V. Levin wrote:
> According to commit 8f6116b5b77b ("statmount: add a new supported_mask
> field"), STATMOUNT_SUPPORTED macro shall be updated whenever a new flag
> is added.
> 
> 

Applied to the vfs-6.16.mount branch of the vfs/vfs.git tree.
Patches in the vfs-6.16.mount branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.16.mount

[1/1] statmount: update STATMOUNT_SUPPORTED macro
      https://git.kernel.org/vfs/vfs/c/ed3453bed26a

Re: [PATCH] statmount: update STATMOUNT_SUPPORTED macro

[Jeff Layton]

On Mon, 2025-05-12 at 01:49 +0300, Dmitry V. Levin wrote:
> According to commit 8f6116b5b77b ("statmount: add a new supported_mask
> field"), STATMOUNT_SUPPORTED macro shall be updated whenever a new flag
> is added.
> 
> Fixes: 7a54947e727b ("Merge patch series "fs: allow changing idmappings"")
> Signed-off-by: Dmitry V. Levin <ldv@strace.io>
> ---
>  fs/namespace.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 1b466c54a357..e321f8bae914 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -5804,7 +5804,9 @@ static int grab_requested_root(struct mnt_namespace *ns, struct path *root)
>  			     STATMOUNT_SB_SOURCE | \
>  			     STATMOUNT_OPT_ARRAY | \
>  			     STATMOUNT_OPT_SEC_ARRAY | \
> -			     STATMOUNT_SUPPORTED_MASK)
> +			     STATMOUNT_SUPPORTED_MASK | \
> +			     STATMOUNT_MNT_UIDMAP | \
> +			     STATMOUNT_MNT_GIDMAP)
>  
>  static int do_statmount(struct kstatmount *s, u64 mnt_id, u64 mnt_ns_id,
>  			struct mnt_namespace *ns)

I guess this patch and the MNT_UID/GIDMAP patches went in around the
same time, and I missed adding them to the mask since I didn't have
that patch in the tree I was working against at the time.

This is probably better for the fixes tag though:

    8f6116b5b77b statmount: add a new supported_mask field

...given that this patch went in just before it.

    37c4a9590e1e statmount: allow to retrieve idmappings

Either way:

Reviewed-by: Jeff Layton <jlayton@kernel.org>