From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Van Hensbergen Subject: Re: [RFC][patch 4/7] v9fs: VFS superblock operations (2.0-rc6) Date: Tue, 24 May 2005 14:08:44 -0500 Message-ID: References: <200505232225.j4NMPte1029529@ms-smtp-02-eri0.texas.rr.com> <84144f0205052400113c6f40fc@mail.gmail.com> Reply-To: Eric Van Hensbergen Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, viro@parcelfarce.linux.theplanet.co.uk, linux-fsdevel@vger.kernel.org, penberg@cs.helsinki.fi Return-path: Received: from wproxy.gmail.com ([64.233.184.198]:64781 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S261510AbVEXTIp convert rfc822-to-8bit (ORCPT ); Tue, 24 May 2005 15:08:45 -0400 Received: by wproxy.gmail.com with SMTP id 68so2780083wri for ; Tue, 24 May 2005 12:08:44 -0700 (PDT) To: Pekka Enberg In-Reply-To: <84144f0205052400113c6f40fc@mail.gmail.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 5/24/05, Pekka Enberg wrote: > > > + > > +/** > > + * find_slab - look up a slab by size > > + * @size: size of slab data > > + * > > + */ > > + > > +static inline kmem_cache_t *find_slab(int size) > > Hmm? Why do you need this? If you're missing functionality from the > slab allocator, please put that in mm/slab.c, not your filesystem! > Thanks for the comments! A bit of a clarification on slab policy - I did my own find_slab() so I could keep tight control over my own slabs (and monitor for slab leaks, etc.). There seems to be similar functionality for the malloc slabs (kmem_find_general_cachep), but I'm not sure if this is really something that is generally useful. What do folks think? Is this something that would be generally useful to add to slab.c? Or is there something like this that I just overlooked? -eric