linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Eric Van Hensbergen" <ericvh@gmail.com>
To: "Latchesar Ionkov" <lucho@ionkov.net>
Cc: linux-kernel@vger.kernel.org,
	v9fs-developer@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] 9p: rename uid and gid parameters
Date: Thu, 13 Sep 2007 08:38:06 -0500	[thread overview]
Message-ID: <a4e6962a0709130638v384c2708y76167d4e92cbac56@mail.gmail.com> (raw)
In-Reply-To: <20070913044718.GB2675@ionkov.net>

On 9/12/07, Latchesar Ionkov <lucho@ionkov.net> wrote:
> Change the names of 'uid' and 'gid' parameters to the more appropriate
> 'dfltuid' and 'dfltgid'.
>

...

>         strcpy(v9ses->name, V9FS_DEFUSER);
>         strcpy(v9ses->remotename, V9FS_DEFANAME);
> +       v9ses->dfltuid = V9FS_DEFUID;
> +       v9ses->dfltgid = V9FS_DEFGID;
>
...
> +#define V9FS_DEFUID    (0)
> +#define V9FS_DEFGID    (0)

I'm not sure if there is a good solution here, but I'm uncomfortable
with using uid=0 as the default.  I'm not sure if there is a default
uid for nobody, but anything is probably better than 0.  Looks like
nfsnobody is 65534, we could use that - even if only as a marker for
the server to map it to nobody on the target system?  What do you
think?

Particularly with attach-per-user, we probably need to look at
interacting with idmapd or create our own variant real soon.

              -eric

  reply	other threads:[~2007-09-13 13:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-13  4:47 [PATCH] 9p: rename uid and gid parameters Latchesar Ionkov
2007-09-13 13:38 ` Eric Van Hensbergen [this message]
2007-09-13 14:51   ` Latchesar Ionkov
2007-09-13 14:55     ` Bernd Petrovitsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4e6962a0709130638v384c2708y76167d4e92cbac56@mail.gmail.com \
    --to=ericvh@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).