From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Van Hensbergen" Subject: Re: [PATCH] 9p: rename uid and gid parameters Date: Thu, 13 Sep 2007 08:38:06 -0500 Message-ID: References: <20070913044718.GB2675@ionkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org To: "Latchesar Ionkov" Return-path: Received: from nf-out-0910.google.com ([64.233.182.184]:64613 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753825AbXIMNiI (ORCPT ); Thu, 13 Sep 2007 09:38:08 -0400 Received: by nf-out-0910.google.com with SMTP id g13so472344nfb for ; Thu, 13 Sep 2007 06:38:06 -0700 (PDT) In-Reply-To: <20070913044718.GB2675@ionkov.net> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 9/12/07, Latchesar Ionkov wrote: > Change the names of 'uid' and 'gid' parameters to the more appropriate > 'dfltuid' and 'dfltgid'. > ... > strcpy(v9ses->name, V9FS_DEFUSER); > strcpy(v9ses->remotename, V9FS_DEFANAME); > + v9ses->dfltuid = V9FS_DEFUID; > + v9ses->dfltgid = V9FS_DEFGID; > ... > +#define V9FS_DEFUID (0) > +#define V9FS_DEFGID (0) I'm not sure if there is a good solution here, but I'm uncomfortable with using uid=0 as the default. I'm not sure if there is a default uid for nobody, but anything is probably better than 0. Looks like nfsnobody is 65534, we could use that - even if only as a marker for the server to map it to nobody on the target system? What do you think? Particularly with attach-per-user, we probably need to look at interacting with idmapd or create our own variant real soon. -eric