From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Van Hensbergen" Subject: Re: [PATCH, v5] 9p: don't print IS_ERR strings Date: Fri, 19 Dec 2008 16:07:53 -0600 Message-ID: References: <1229719638-6982-1-git-send-email-duaneg@dghda.com> <1229719638-6982-2-git-send-email-duaneg@dghda.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Al Viro" , "Andrew Morton" , "Ron Minnich" , "Latchesar Ionkov" , v9fs-developer@lists.sourceforge.net To: "Duane Griffin" Return-path: Received: from rv-out-0506.google.com ([209.85.198.236]:44525 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757894AbYLSWHz (ORCPT ); Fri, 19 Dec 2008 17:07:55 -0500 In-Reply-To: <1229719638-6982-2-git-send-email-duaneg@dghda.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: NAK - the print is a debug to mark function entry when debugging is on -- it is not intended to show only success. If an erroneous s will cause the print to break then perhaps it should be parameterized, but the entire print shouldn't be pushed inside the if statement. -eric On Fri, Dec 19, 2008 at 2:47 PM, Duane Griffin wrote: > Move the printk inside the !IS_ERR test. > > Cc: Eric Van Hensbergen > Cc: Ron Minnich > Cc: Latchesar Ionkov > Cc: v9fs-developer@lists.sourceforge.net > Signed-off-by: Duane Griffin > --- > > Unchanged from original version. > > fs/9p/vfs_inode.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c > index 8fddfe8..c50d555 100644 > --- a/fs/9p/vfs_inode.c > +++ b/fs/9p/vfs_inode.c > @@ -1022,9 +1022,10 @@ v9fs_vfs_put_link(struct dentry *dentry, struct nameidata *nd, void *p) > { > char *s = nd_get_link(nd); > > - P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, s); > - if (!IS_ERR(s)) > + if (!IS_ERR(s)) { > + P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, s); > __putname(s); > + } > } > > /** > -- > 1.6.0.4 > >