From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Satyam Sharma" Subject: Re: [BUG?]Set XIP mount option on ext2 bypass check. Date: Fri, 22 Jun 2007 17:49:41 +0530 Message-ID: References: <4679A58C.2080008@21cn.com> <467A5E36.9030904@de.ibm.com> <1182431869.7145.7.camel@cotte.boeblingen.de.ibm.com> <200706220122.41586.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Carsten Otte" , "Andrew Morton" , "Yan Zheng" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: "Arnd Bergmann" Return-path: Received: from nz-out-0506.google.com ([64.233.162.232]:11075 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751987AbXFVMTm (ORCPT ); Fri, 22 Jun 2007 08:19:42 -0400 Received: by nz-out-0506.google.com with SMTP id n1so914378nzf for ; Fri, 22 Jun 2007 05:19:41 -0700 (PDT) In-Reply-To: <200706220122.41586.arnd@arndb.de> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi, On 6/22/07, Arnd Bergmann wrote: > On Thursday 21 June 2007, Carsten Otte wrote: > > > > This is an updated version of my bugfix patch. Yan Zheng pointed out, > > that ext2_remount lacks checking if -o xip should be enabled or not. > > This patch checks for presence of direct_access on the backing block > > device and if the blocksize meets the requirements. > > Andrew, please consider adding this patch to -mm. > > > > Signed-off-by: Carsten Otte > > It looks to me like a local denial of service attack in case of > user-mountable ext2 file systems in /etc/fstab. > > Shouldn't that make it go into 2.6.22? I agree. I would go on to suggest that all trivially-triggered oopsen / panics from userspace (even if they require privileges, such as the cat /dev/snapshot == oops issue posted last week) in fact ought to be CVE's, and the corresponding fixes for such issues be considered as candidates for -stable, if applicable to the current stable kernel. Satyam