From: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
To: Carlos Maiolino <cem@kernel.org>
Cc: Kent Overstreet <kent.overstreet@linux.dev>,
Jonathan Corbet <corbet@lwn.net>,
David Howells <dhowells@redhat.com>,
Paulo Alcantara <pc@manguebit.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-bcachefs@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org, david.hunter.linux@gmail.com
Subject: Re: [PATCH] fs: doc: Fix typos
Date: Sat, 4 Oct 2025 10:03:22 +0530 [thread overview]
Message-ID: <a87756f6-b578-421e-b04b-b1dd15f3a2f1@gmail.com> (raw)
In-Reply-To: <kp4tzf7hvtorldoktxelrvway6w4v4idmu5q3egeaacs7eg2tz@dovkk323ir3b>
On 01/10/25 17:32, Carlos Maiolino wrote:
> On Wed, Oct 01, 2025 at 02:09:31PM +0530, Bhanu Seshu Kumar Valluri wrote:
>> Fix typos in doc comments
>>
>> Signed-off-by: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
>
> Perhaps would be better to split this into subsystem-specific patches?
>
> This probably needs to be re-sent anyway as bcachefs was removed from
> mainline.
>
>
>> ---
>> Note: No change in functionality intended.
>>
>> Documentation/filesystems/bcachefs/future/idle_work.rst | 6 +++---
>> Documentation/filesystems/xfs/xfs-online-fsck-design.rst | 2 +-
>> fs/netfs/buffered_read.c | 2 +-
>> fs/xfs/xfs_linux.h | 2 +-
>> include/linux/fs.h | 4 ++--
>> 5 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/Documentation/filesystems/bcachefs/future/idle_work.rst b/Documentation/filesystems/bcachefs/future/idle_work.rst
>> index 59a332509dcd..f1202113dde0 100644
>> --- a/Documentation/filesystems/bcachefs/future/idle_work.rst
>> +++ b/Documentation/filesystems/bcachefs/future/idle_work.rst
>> @@ -11,10 +11,10 @@ idle" so the system can go to sleep. We don't want to be dribbling out
>> background work while the system should be idle.
>>
>> The complicating factor is that there are a number of background tasks, which
>> -form a heirarchy (or a digraph, depending on how you divide it up) - one
>> +form a hierarchy (or a digraph, depending on how you divide it up) - one
>> background task may generate work for another.
>>
>> -Thus proper idle detection needs to model this heirarchy.
>> +Thus proper idle detection needs to model this hierarchy.
>>
>> - Foreground writes
>> - Page cache writeback
>> @@ -51,7 +51,7 @@ IDLE REGIME
>> When the system becomes idle, we should start flushing our pending work
>> quicker so the system can go to sleep.
>>
>> -Note that the definition of "idle" depends on where in the heirarchy a task
>> +Note that the definition of "idle" depends on where in the hierarchy a task
>> is - a task should start flushing work more quickly when the task above it has
>> stopped generating new work.
>>
>> diff --git a/Documentation/filesystems/xfs/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
>> index e231d127cd40..e872d480691b 100644
>> --- a/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
>> +++ b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
>> @@ -4179,7 +4179,7 @@ When the exchange is initiated, the sequence of operations is as follows:
>> This will be discussed in more detail in subsequent sections.
>>
>> If the filesystem goes down in the middle of an operation, log recovery will
>> -find the most recent unfinished maping exchange log intent item and restart
>> +find the most recent unfinished mapping exchange log intent item and restart
>> from there.
>> This is how atomic file mapping exchanges guarantees that an outside observer
>> will either see the old broken structure or the new one, and never a mismash of
>> diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c
>> index 37ab6f28b5ad..c81be6390309 100644
>> --- a/fs/netfs/buffered_read.c
>> +++ b/fs/netfs/buffered_read.c
>> @@ -329,7 +329,7 @@ static void netfs_read_to_pagecache(struct netfs_io_request *rreq,
>> * the netfs if not. Space beyond the EOF is zero-filled. Multiple I/O
>> * requests from different sources will get munged together. If necessary, the
>> * readahead window can be expanded in either direction to a more convenient
>> - * alighment for RPC efficiency or to make storage in the cache feasible.
>> + * alignment for RPC efficiency or to make storage in the cache feasible.
>> *
>> * The calling netfs must initialise a netfs context contiguous to the vfs
>> * inode before calling this.
>> diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
>> index 9a2221b4aa21..fdf3cd8c4d19 100644
>> --- a/fs/xfs/xfs_linux.h
>> +++ b/fs/xfs/xfs_linux.h
>> @@ -145,7 +145,7 @@ static inline void delay(long ticks)
>> /*
>> * XFS wrapper structure for sysfs support. It depends on external data
>> * structures and is embedded in various internal data structures to implement
>> - * the XFS sysfs object heirarchy. Define it here for broad access throughout
>> + * the XFS sysfs object hierarchy. Define it here for broad access throughout
>> * the codebase.
>> */
>> struct xfs_kobj {
>> diff --git a/include/linux/fs.h b/include/linux/fs.h
>> index 601d036a6c78..72e82a4a0bbc 100644
>> --- a/include/linux/fs.h
>> +++ b/include/linux/fs.h
>> @@ -1040,7 +1040,7 @@ struct fown_struct {
>> * struct file_ra_state - Track a file's readahead state.
>> * @start: Where the most recent readahead started.
>> * @size: Number of pages read in the most recent readahead.
>> - * @async_size: Numer of pages that were/are not needed immediately
>> + * @async_size: Number of pages that were/are not needed immediately
>> * and so were/are genuinely "ahead". Start next readahead when
>> * the first of these pages is accessed.
>> * @ra_pages: Maximum size of a readahead request, copied from the bdi.
>> @@ -3149,7 +3149,7 @@ static inline void kiocb_start_write(struct kiocb *iocb)
>>
>> /**
>> * kiocb_end_write - drop write access to a superblock after async file io
>> - * @iocb: the io context we sumbitted the write with
>> + * @iocb: the io context we submitted the write with
>> *
>> * Should be matched with a call to kiocb_start_write().
>> */
>> --
>> 2.34.1
>>
Hi,
Thanks for pointing out the fact that the bcachefs is now externally maintained.
I will exclude it in my future versions and will split the patch in to subsystem specific.
Regards,
Bhanu Seshu Kumar Valluri
next prev parent reply other threads:[~2025-10-04 4:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DrG_H24-pk-ha8vkOEHoZYVXyMFA60c_g4l7cZX4Z7lnKQIM4FjdI_qS-UIpFxa-t7T_JDAOSqKjew7M0wmYYw==@protonmail.internalid>
2025-10-01 8:39 ` [PATCH] fs: doc: Fix typos Bhanu Seshu Kumar Valluri
2025-10-01 9:36 ` David Howells
2025-10-01 12:02 ` Carlos Maiolino
2025-10-01 13:49 ` Bhanu Seshu Kumar Valluri
2025-10-03 15:52 ` Carlos Maiolino
2025-10-04 4:31 ` Bhanu Seshu Kumar Valluri
2025-10-04 4:33 ` Bhanu Seshu Kumar Valluri [this message]
2025-10-01 16:53 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a87756f6-b578-421e-b04b-b1dd15f3a2f1@gmail.com \
--to=bhanuseshukumar@gmail.com \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=corbet@lwn.net \
--cc=david.hunter.linux@gmail.com \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
--cc=skhan@linuxfoundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).