From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B191414ABF for ; Thu, 2 Nov 2023 11:49:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="SKVfTG98" Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF169E4; Thu, 2 Nov 2023 04:49:52 -0700 (PDT) Received: from [100.98.85.67] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 35E696603102; Thu, 2 Nov 2023 11:49:44 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698925791; bh=DnwHAYWfAm3XZipZksuQGXF6sjFyFFaQUCgEARzx934=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=SKVfTG98EttX7MvGf7/J9/7o9DENZJm5T53wD2AxQHucm9rfKzRBoLdUq3eaY6Tyr nnW2hbmTZGZOE+Ob2DHwLFU1t6+jthHUubGWxwLZqGB4y6PDX2m50UVt0zGGV5pvl5 yZT6Il+zrTYuFrtEV90z5JjqR1TyVyR0dj4QAzohaVpY6Av92xVj+0X4KeGTJkoNs5 G/cYlPaAliy5FnwOTM2qFGRkckMwrSJHdpuB7HJb96c6ac4vobTiT22EEtPT0vvb/e s7OGvqe11DzO6W0Ru0v87mDXSHdbEUCQd4Cjeknr2FndxH67JxejfM/xMbbrjLDx7e /wm3YpqUoO4yw== Message-ID: Date: Thu, 2 Nov 2023 16:49:41 +0500 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com, Cyrill Gorcunov , Mike Rapoport , Nadav Amit , David Hildenbrand Subject: Re: [PATCH v33 6/6] selftests: mm: add pagemap ioctl tests Content-Language: en-US To: Ryan Roberts , Peter Xu , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WC?= =?UTF-8?Q?aw?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman References: <20230821141518.870589-1-usama.anjum@collabora.com> <20230821141518.870589-7-usama.anjum@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/2/23 4:45 PM, Ryan Roberts wrote: > On 21/08/2023 15:15, Muhammad Usama Anjum wrote: > > [...] > >> + >> + >> +int init_uffd(void) >> +{ >> + struct uffdio_api uffdio_api; >> + >> + uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK | UFFD_USER_MODE_ONLY); >> + if (uffd == -1) >> + ksft_exit_fail_msg("uffd syscall failed\n"); >> + >> + uffdio_api.api = UFFD_API; >> + uffdio_api.features = UFFD_FEATURE_WP_UNPOPULATED | UFFD_FEATURE_WP_ASYNC | >> + UFFD_FEATURE_WP_HUGETLBFS_SHMEM; >> + if (ioctl(uffd, UFFDIO_API, &uffdio_api)) >> + ksft_exit_fail_msg("UFFDIO_API\n"); >> + >> + if (!(uffdio_api.api & UFFDIO_REGISTER_MODE_WP) || >> + !(uffdio_api.features & UFFD_FEATURE_WP_UNPOPULATED) || >> + !(uffdio_api.features & UFFD_FEATURE_WP_ASYNC) || >> + !(uffdio_api.features & UFFD_FEATURE_WP_HUGETLBFS_SHMEM)) >> + ksft_exit_fail_msg("UFFDIO_API error %llu\n", uffdio_api.api); > > Hi, > > I've just noticed that this fails on arm64 because the required features are not > available. It's common practice to skip instead of fail for this sort of > condition (and that's how all the other uffd tests work). The current fail > approach creates noise in our CI. > > I see this is already in mm-stable so perhaps we can add a patch to fix on top? Yeah, we can add a patch to skip all the tests instead of failing here. Let me send a patch this week. > > Thanks, > Ryan > > -- BR, Muhammad Usama Anjum