linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Mark Harmstone <mark@harmstone.com>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Cc: "Pali Rohár" <pali@kernel.org>
Subject: RE: [PATCH v2 05/10] fs/ntfs3: Add attrib operations
Date: Fri, 4 Sep 2020 12:52:07 +0000	[thread overview]
Message-ID: <a9e1e31b909346faa9b398db9fa33ba1@paragon-software.com> (raw)
In-Reply-To: <3c1e5918-347a-d1e6-44ce-338c7d0dc7e4@harmstone.com>

From: Mark Harmstone <mark.harmstone@gmail.com> On Behalf Of Mark Harmstone
Sent: Saturday, August 29, 2020 3:54 PM
> On 28/8/20 5:52 pm, Konstantin Komarov wrote:
> > Hi Mark! Thanks for the feedback. It's reasonable concern, but the open
> > question is how to access those NTFS attributes which extend the DOS
> > attributes. user.DOSATTRIB may be good for FAT32 as DOS attributes are stored in 8bit.
> > However, this does not apply to NTFS (32bit attributes).
> 
> I'm not sure why this would be an issue - the obvious way of reading
> user.DOSATTRIB is to use sscanf into an int, and then check for the bits you're
> interested in. The NT FILE_ATTRIBUTE_* values replicate and extend the FAT
> constants used by DOS, so it shouldn't cause any confusion only exposing the
> full 32-bit value.

Hi Mark! First, in v4 we've removed smbd-exclusive access to
user.DOSATTRIB. Overall, we agree that unified access is preferred.
If everyone is fine with sticking to user.DOSATTRIB, we'll remove
other options in next patches.

  reply	other threads:[~2020-09-04 12:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 16:52 [PATCH v2 05/10] fs/ntfs3: Add attrib operations Konstantin Komarov
2020-08-29 12:53 ` Mark Harmstone
2020-09-04 12:52   ` Konstantin Komarov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-08-21 16:25 Konstantin Komarov
2020-08-24 16:14 ` Mark Harmstone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9e1e31b909346faa9b398db9fa33ba1@paragon-software.com \
    --to=almaz.alexandrovich@paragon-software.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@harmstone.com \
    --cc=pali@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).