From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BFC02376F8 for ; Mon, 5 May 2025 14:36:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746455766; cv=none; b=kVJV4UFQqM1Yr6+rvxxqSRW3S07AaOFqz8ZraM+SEvf3iFNfzYa5FCQngAqa9QY0aPA27ucqOxWQAJTCiKLV+QgCnLUjwEj0EghKhHzV/rAsAACG29eYQcPlExzqxT3ok+lTKhaGg98nZOh5177D+P4eX424O4dj6pi8+pzaMX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746455766; c=relaxed/simple; bh=NiI0SBUsKfVpu0bDBlAYkaz3dlUVkI3VQo63VHd3cgA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fjbh+dFwm0nEG+7iyU4tYIerbo2vsSaQoxOKRXhv8zYQUQ1bDye+wFekY1DkDfJCrPX4xtyixK4hne9MYG+97jnKTmQjP+8wYKmHY09BuNMsQVQCkpAyapW+58nqrY9s92fCXOQmBpC7p3xR/W9GPENU3KtQ6tGCxyWinkyzx2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EypIDVeL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EypIDVeL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746455763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zQ12Lp7Fa/GVMIpOsV31AcmZU5JB46fQ8f0PIoZ9GfI=; b=EypIDVeLZpaLk9Y4Gqfzbll9Y5aCSZi94cPxDNT8aa+jYE4CJLeazEYPJ0BG5H0GMXH0QH I/o8U2N7clZRJQQZ7YHyh5ZMiO/T0HikXRzWDEdrfznYxcX93rEXlJmrlcCT0F5wBUNgHa GJfLAOG1okpC/w+b53fAjD3U6G7BsFg= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-1AN63fzMMheKjOgrOoopSw-1; Mon, 05 May 2025 10:36:02 -0400 X-MC-Unique: 1AN63fzMMheKjOgrOoopSw-1 X-Mimecast-MFC-AGG-ID: 1AN63fzMMheKjOgrOoopSw_1746455761 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 155F4180087A; Mon, 5 May 2025 14:36:01 +0000 (UTC) Received: from bfoster (unknown [10.22.64.112]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4B54D1954B00; Mon, 5 May 2025 14:36:00 +0000 (UTC) Date: Mon, 5 May 2025 10:39:11 -0400 From: Brian Foster To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 6/6] iomap: rework iomap_write_begin() to return folio offset and length Message-ID: References: <20250430190112.690800-1-bfoster@redhat.com> <20250430190112.690800-7-bfoster@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Mon, May 05, 2025 at 02:05:03AM -0700, Christoph Hellwig wrote: > On Wed, Apr 30, 2025 at 03:01:12PM -0400, Brian Foster wrote: > > + len = *plen > 0 ? min_t(u64, len, *plen) : len; > > len = min_not_zero(len, *plen); > Ah, nice. Thanks. Brian > Otherwise looks good: > > Reviewed-by: Christoph Hellwig >