From: Sasha Levin <sashal@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Hannes Reinecke <hare@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Hannes Reinecke <hare@suse.de>,
Christian Brauner <brauner@kernel.org>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.14 342/642] fs/mpage: avoid negative shift for large blocksize
Date: Tue, 6 May 2025 09:51:47 -0400 [thread overview]
Message-ID: <aBoT89awjNjboEe8@lappy> (raw)
In-Reply-To: <aBlfg8tuWY1_GVPJ@bombadil.infradead.org>
On Mon, May 05, 2025 at 06:01:55PM -0700, Luis Chamberlain wrote:
>On Mon, May 05, 2025 at 06:09:18PM -0400, Sasha Levin wrote:
>> From: Hannes Reinecke <hare@kernel.org>
>>
>> [ Upstream commit 86c60efd7c0ede43bd677f2eee1d84200528df1e ]
>>
>> For large blocksizes the number of block bits is larger than PAGE_SHIFT,
>> so calculate the sector number from the byte offset instead. This is
>> required to enable large folios with buffer-heads.
>>
>> Reviewed-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
>> Signed-off-by: Hannes Reinecke <hare@kernel.org>
>> Link: https://lore.kernel.org/r/20250221223823.1680616-4-mcgrof@kernel.org
>> Reviewed-by: Hannes Reinecke <hare@suse.de>
>> Signed-off-by: Christian Brauner <brauner@kernel.org>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>This is not relevant to older kernels as we had no buffer-head usage of
>large folios before v6.15. So this is just creating noise / drama for
>older kernels.
Sure, I'll drop it.
>Where's that code for auto-sel again?
https://git.sr.ht/~sashal/autosel :)
--
Thanks,
Sasha
prev parent reply other threads:[~2025-05-06 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250505221419.2672473-1-sashal@kernel.org>
2025-05-05 22:03 ` [PATCH AUTOSEL 6.14 009/642] fuse: Return EPERM rather than ENOSYS from link() Sasha Levin
2025-05-05 22:03 ` [PATCH AUTOSEL 6.14 010/642] exfat: call bh_read in get_block only when necessary Sasha Levin
2025-05-05 22:04 ` [PATCH AUTOSEL 6.14 067/642] pidfs: improve multi-threaded exec and premature thread-group leader exit polling Sasha Levin
2025-05-05 22:07 ` [PATCH AUTOSEL 6.14 209/642] fs/pipe: Limit the slots in pipe_resize_ring() Sasha Levin
2025-05-05 22:09 ` [PATCH AUTOSEL 6.14 342/642] fs/mpage: avoid negative shift for large blocksize Sasha Levin
2025-05-06 1:01 ` Luis Chamberlain
2025-05-06 13:51 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBoT89awjNjboEe8@lappy \
--to=sashal@kernel.org \
--cc=brauner@kernel.org \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).