linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org, chao@kernel.org,
	lihongbo22@huawei.com
Subject: Re: [PATCH V3 0/7] f2fs: new mount API conversion
Date: Wed, 7 May 2025 01:23:38 +0000	[thread overview]
Message-ID: <aBq2GrqV9hw5cTyJ@google.com> (raw)
In-Reply-To: <f9170e82-a795-4d74-89f5-5c7c9d233978@redhat.com>

On 05/06, Eric Sandeen wrote:
> On 5/6/25 7:35 PM, Jaegeuk Kim wrote:
> > Hmm, I had to drop the series at the moment, since it seems needing more
> > work to deal with default_options(), which breaks my device setup.
> > For example, set_opt(sbi, READ_EXTENT_CACHE) in default_options is not propagating
> > to the below logics. In this case, do we need ctx_set_opt() if user doesn't set?
> 
> Hm, can you describe the test or environment that fails for you?
> (I'm afraid that I may not have all the right hardware to test everything,
> so may have missed some cases)
> 
> However, from a quick test here, a loopback mount of an f2fs image file does
> set extent_cache properly, so maybe I don't understand the problem:
> 
> # mount -o loop f2fsfile.img mnt
> # mount | grep -o extent_cache
> extent_cache
> #
> 
> I'm happy to try to look into it though. Maybe you can put the patches
> back on a temporary branch for me to pull and test?

Thank you! I pushed here the last version.

https://github.com/jaegeuk/f2fs/commits/mount/

What about:
# mount -o loop,noextent_cache f2fsfile.img mnt

In this case, 1) ctx_clear_opt(), 2) set_opt() in default_options,
3) clear_opt since mask is set?

And, device_aliasing check is still failing, since it does not understand
test_opt(). Probably it's the only case?

> 
> Thanks,
> - Eric
> 

  reply	other threads:[~2025-05-07  1:23 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23 17:08 [PATCH V3 0/7] f2fs: new mount API conversion Eric Sandeen
2025-04-23 17:08 ` [PATCH V3 1/7] f2fs: Add fs parameter specifications for mount options Eric Sandeen
2025-05-08  2:40   ` Hongbo Li
2025-05-08  5:24   ` Chao Yu
2025-07-11 16:30   ` [f2fs-dev] " patchwork-bot+f2fs
2025-04-23 17:08 ` [PATCH V3 2/7] f2fs: move the option parser into handle_mount_opt Eric Sandeen
2025-05-06 20:24   ` Jaegeuk Kim
2025-05-08  5:30   ` Chao Yu
2025-04-23 17:08 ` [PATCH V3 3/7] f2fs: Allow sbi to be NULL in f2fs_printk Eric Sandeen
2025-05-08  5:30   ` Chao Yu
2025-04-23 17:08 ` [PATCH V3 4/7] f2fs: Add f2fs_fs_context to record the mount options Eric Sandeen
2025-05-08  6:34   ` Chao Yu
2025-04-23 17:08 ` [PATCH V3 5/7] f2fs: separate the options parsing and options checking Eric Sandeen
2025-05-06 22:01   ` Jaegeuk Kim
2025-05-06 22:52     ` Eric Sandeen
2025-05-06 23:30       ` Jaegeuk Kim
2025-05-08  8:13   ` Chao Yu
2025-05-08 15:52     ` Eric Sandeen
2025-05-12  3:32       ` Chao Yu
2025-05-14  1:10         ` Hongbo Li
2025-05-14  1:03       ` Hongbo Li
2025-05-13  2:15   ` Jaegeuk Kim
2025-04-23 17:08 ` [PATCH V3 6/7] f2fs: introduce fs_context_operation structure Eric Sandeen
2025-05-08  8:14   ` Chao Yu
2025-04-23 17:08 ` [PATCH V3 7/7] f2fs: switch to the new mount api Eric Sandeen
2025-05-08  9:19   ` Chao Yu
2025-05-08 15:59     ` Eric Sandeen
2025-05-12  3:43       ` Chao Yu
2025-05-13  2:19         ` Eric Sandeen
2025-05-13  2:48           ` Chao Yu
2025-05-13 15:36             ` Jaegeuk Kim
2025-05-13  8:59   ` Chao Yu
2025-05-14  2:33     ` Hongbo Li
2025-05-14  4:03       ` Chao Yu
2025-05-14  6:15         ` Hongbo Li
2025-05-14 15:30           ` Jaegeuk Kim
2025-05-14 15:46             ` Eric Sandeen
2025-05-15  1:17             ` Hongbo Li
2025-05-16  2:01             ` Hongbo Li
2025-05-16 17:35               ` Jaegeuk Kim
2025-05-19  2:38                 ` Hongbo Li
2025-05-13 16:11   ` Jaegeuk Kim
2025-05-06  2:18 ` [PATCH V3 0/7] f2fs: new mount API conversion Eric Sandeen
2025-05-06 16:02   ` Jaegeuk Kim
2025-05-06 22:53     ` Eric Sandeen
2025-05-06 23:55 ` Ian Kent
2025-05-07  0:35 ` Jaegeuk Kim
2025-05-07  0:51   ` Eric Sandeen
2025-05-07  1:23     ` Jaegeuk Kim [this message]
2025-05-07  2:56       ` Eric Sandeen
2025-05-07  3:45         ` Eric Sandeen
2025-05-07 14:46           ` Jaegeuk Kim
2025-05-07 17:11             ` Eric Sandeen
2025-05-07 19:48               ` Jaegeuk Kim
2025-05-07 20:19                 ` Eric Sandeen
2025-05-07 20:28                   ` Jaegeuk Kim
2025-05-07 20:46                     ` Eric Sandeen
2025-05-07 21:36                       ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBq2GrqV9hw5cTyJ@google.com \
    --to=jaegeuk@kernel.org \
    --cc=chao@kernel.org \
    --cc=lihongbo22@huawei.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).