From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
djwong@kernel.org, brauner@kernel.org,
torvalds@linux-foundation.org, trondmy@hammerspace.com,
stable@vger.kernel.org
Subject: Re: [PATCH 1/5] mm/filemap: gate dropbehind invalidate on folio !dirty && !writeback
Date: Wed, 28 May 2025 01:12:54 -0700 [thread overview]
Message-ID: <aDbFhjfbszpAtK-9@infradead.org> (raw)
In-Reply-To: <20250527133255.452431-2-axboe@kernel.dk>
On Tue, May 27, 2025 at 07:28:52AM -0600, Jens Axboe wrote:
> It's possible for the folio to either get marked for writeback or
> redirtied. Add a helper, filemap_end_dropbehind(), which guards the
> folio_unmap_invalidate() call behind check for the folio being both
> non-dirty and not under writeback AFTER the folio lock has been
> acquired. Use this helper folio_end_dropbehind_write().
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-05-28 8:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 13:28 [PATCHSET 0/5] dropbehind fixes and cleanups Jens Axboe
2025-05-27 13:28 ` [PATCH 1/5] mm/filemap: gate dropbehind invalidate on folio !dirty && !writeback Jens Axboe
2025-05-28 8:12 ` Christoph Hellwig [this message]
2025-05-27 13:28 ` [PATCH 2/5] mm/filemap: use filemap_end_dropbehind() for read invalidation Jens Axboe
2025-05-28 8:13 ` Christoph Hellwig
2025-05-27 13:28 ` [PATCH 3/5] Revert "Disable FOP_DONTCACHE for now due to bugs" Jens Axboe
2025-05-28 8:14 ` Christoph Hellwig
2025-05-27 13:28 ` [PATCH 4/5] mm/filemap: unify read/write dropbehind naming Jens Axboe
2025-05-28 8:14 ` Christoph Hellwig
2025-05-27 13:28 ` [PATCH 5/5] mm/filemap: unify dropbehind flag testing and clearing Jens Axboe
2025-05-28 8:15 ` Christoph Hellwig
2025-05-27 19:10 ` [PATCHSET 0/5] dropbehind fixes and cleanups Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDbFhjfbszpAtK-9@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trondmy@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).