From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Yafang Shao <laoar.shao@gmail.com>,
Jeff Layton <jlayton@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
djwong@kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
yc1082463@gmail.com
Subject: Re: [PATCH] xfs: report a writeback error on a read() call
Date: Thu, 26 Jun 2025 03:25:21 -0700 [thread overview]
Message-ID: <aF0gEWcA6bX1eNzU@infradead.org> (raw)
In-Reply-To: <aFzFR6zD7X1_9bWj@dread.disaster.area>
On Thu, Jun 26, 2025 at 01:57:59PM +1000, Dave Chinner wrote:
> writeback errors. Because scientists and data analysts that wrote
> programs to chew through large amounts of data didn't care about
> persistence of their data mid-processing. They just wanted what they
> wrote to be there the next time the processing pipeline read it.
That's only going to work if your RAM is as large as your permanent
storage :)
> IOWs, checking for a past writeback IO error is as simple as:
>
> if (sync_file_range(fd, 0, 0, SYNC_FILE_RANGE_WAIT_BEFORE) < 0) {
> /* An unreported writeback error was pending on the file */
> wb_err = -errno;
> ......
> }
>
> This does not cause new IO to be issued, it only blocks on writeback
> that is currently in progress, and it has no data integrity
> requirements at all. If the writeback has already been done, all it
> will do is sweep residual errors out to userspace.....
Not quite.
This will still wait for all I/O on the range, and given that
sync_file_range treats a 0 length as the entire file that might actually
do a significant amount of waiting. But yes, it's the closest we get
right now.
next prev parent reply other threads:[~2025-06-26 10:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAN2Y7hyi1HCrSiKsDT+KD8hBjQmsqzNp71Q9Z_RmBG0LLaZxCA@mail.gmail.com>
2025-06-24 14:14 ` [PATCH] xfs: report a writeback error on a read() call Christoph Hellwig
2025-06-24 18:26 ` Jeff Layton
2025-06-24 19:56 ` Matthew Wilcox
2025-06-24 20:25 ` Jeff Layton
2025-06-25 2:44 ` Yafang Shao
2025-06-25 7:01 ` Christoph Hellwig
2025-06-25 10:40 ` Jeff Layton
2025-06-25 11:21 ` Christoph Hellwig
2025-06-25 11:49 ` Jeff Layton
2025-06-25 11:56 ` Christoph Hellwig
2025-06-25 14:06 ` Jeff Layton
2025-06-26 2:41 ` Yafang Shao
2025-06-26 3:57 ` Dave Chinner
2025-06-26 10:25 ` Christoph Hellwig [this message]
2025-06-26 22:22 ` Dave Chinner
2025-06-27 21:19 ` Matthew Wilcox
2025-06-26 10:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF0gEWcA6bX1eNzU@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jlayton@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yc1082463@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).